Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the invitation system #201

Merged
merged 20 commits into from
Dec 7, 2023
Merged

Improve the invitation system #201

merged 20 commits into from
Dec 7, 2023

Conversation

meln1k
Copy link
Member

@meln1k meln1k commented Dec 7, 2023

Description

To-Dos

  • Add test coverage for new or updated functionality
  • Lint and test with nox

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

meln1k added 19 commits December 6, 2023 11:38
@meln1k
extract invitations into its own repo
4921e0d
@meln1k
rename workspace invite to workspace invitation
3c464fc
@meln1k
move the email sending thing into its own class
eb90d9e
@meln1k
list workspaces based on membership
d3e637b
@meln1k
Add invitation repository tests
e8b9c7b
@meln1k
update the migration
b2098f0
@meln1k
Add abstractmethod to NotificationService
d1c68e5
@meln1k
Add the invitation service tests
3f9aebe
@meln1k
update the models and orm
53656c2
@meln1k
adjust the other tests
62b3d32
@meln1k
make user manager invite to workspace after registration
3f18e05
@meln1k
Update the workspace router tests
3ecc1f4
@meln1k
Fix invitation repository implementation and usage
15ad7f8 
in the code
@meln1k
remove user_id from the invite
d066b54
@meln1k
silence poetry when installing in nox
bc0ffa4
@meln1k
fix migration
10e6d5d
@meln1k
accept json payload and redirect after accepting invite
6629809
@meln1k
publish domain events
27328d5
@meln1k
add websocket notifications about users that joined the workspaces
b9c8a6b
aquamatthias
aquamatthias previously approved these changes Dec 7, 2023
View reviewed changes
Copy link
Member

@aquamatthias aquamatthias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@meln1k meln1k merged commit e49d953 into main Dec 7, 2023
2 checks passed
@meln1k meln1k deleted the nm/invitation-system-rework branch December 7, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aquamatthias aquamatthias aquamatthias approved these changes

@lloesche lloesche Awaiting requested review from lloesche lloesche is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@meln1k @aquamatthias