Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to ignore lines during the parse #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

herbertpimentel
Copy link

To address my need to from issue #8 this was the most basic and easy to solve the problem and still keep the spirit of the library.

I have add a support for multiples <ignore>regex</ignore> tags. This way now we have ability to entire skip undesired lines from the file.

@daniel-bray-sonalake
Copy link
Collaborator

We'll check this out shortly. We'll also update the build to use something newer than java 7 ;)

@daniel-bray-sonalake
Copy link
Collaborator

Sorry for the delay; I had some trouble getting the time together to get this building on JDK 9+

Can you merge master back into this branch and check it again, please? The jaxb stuff we used to use for config management is gone from the JDK now, we replaced it with jackson.

This means the changes to src/main/java/com/sonalake/utah/config/Config.java would need to be updated.

Thanks

@daniel-bray-sonalake
Copy link
Collaborator

Hi, keep in mind that this will be built using jdk 11 as the compiler, so imports like this, in com.sonalake.utah.config.Ignorer won't compile after the merge.

import javax.xml.bind.annotation.XmlValue;

If you don't know it, check out http://www.jenv.be/ - it makes it really easy to use different java versions for different products.

@daniel-bray-sonalake
Copy link
Collaborator

I'll update the main project to skip over the gpg signing on PRs

@daniel-bray-sonalake
Copy link
Collaborator

If you can pull master back into your PR, there is an updated .travis.yml that will skip over the GPG signing during the PR builds.

This was what was failing in the last travis build because you don't have our secret keys ;)

@daniel-bray-sonalake
Copy link
Collaborator

@herbertpimentel, we've moved to a new build process for this project. Can you update the PR to merge it into the develop branch, so we can try to load it in again, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants