Allow to select the branch to release

[VincentLanglet]

I used it for sonata-project/SonataBlockBundle#879

[VincentLanglet]

I made the code BC for the controller which display the next release.

But should we update them in order to display all the branches ?
This way we won't miss a potential release (for instance for the [email protected]).

WDYT @sonata-project/contributors ?

[VincentLanglet]

I need to make more test for release on master branch. But I'm currently getting

 You have reached GitHub hourly limit! Actual limit is: 60

[jordisala1991]

I like the idea, and it is probably a good solution, but we have a problem with the github api calls. One question, does packagist expose an api for releases?

[VincentLanglet]

I don't know why but I'm getting

[WARNING] Release is not needed

When trying to run the command with admin-bundle and master branch.

cc @OskarStark

[VincentLanglet]

I like the idea, and it is probably a good solution, but we have a problem with the github api calls. One question, does packagist expose an api for releases?

It's not supposed to make a lot more calls than before.

• When running bin/console release it's supposed to do the same calls.
• On the controller, it will make more calls for project with multiple stable branch, I think block-bundle is the only one. So it's just like having one project more to check for release.

I'm not sure packagist would be better since we still have a lot of github checks to do. We should look for caching calls or having more call to github per hour...

[jordisala1991]

we should have 5000 calls per hour: https://docs.github.com/es/rest/overview/resources-in-the-rest-api#rate-limiting

something is wrong here

[jordisala1991]

Did you add your github token on .env?

[VincentLanglet]

Did you add your github token on .env?

Yes. But when I dump the authenticate method it seems like it's not called.
It's like the config

    Github\Client:
        arguments:
            - '@Github\HttpClient\Builder'
        calls:
            - ['authenticate', ['%env(GITHUB_OAUTH_TOKEN)%', null, 'access_token_header']]
            - ['addCache', ['@Cache\Adapter\Redis\RedisCachePool']]

is not used

[VincentLanglet]

Yes, if I call manually $this->github->authenticate it works.

[VincentLanglet]

This also explain why the cache is not used on the website.

Now, how to fix this ?

[VincentLanglet]

Adding

    _defaults:
        # The Github\Client is only calling authenticate/addCache when public (but I don't know why)
        public: true
        autowire: true
        autoconfigure: true

Does call authenticate

I don't know why it need to be public...

[OskarStark]

Nice catch, can you open an issue on the repo and ask?

[VincentLanglet]

Should it be on the Github\Client repo or on the symfony repo ?

[franmomu]

I'm curious why that would happen, just making Github\Client public fixes the issue or should all services defined there be public?

I've never used the commands.

[VincentLanglet]

I just discovered that I don't need to add

    _defaults:
        # The Github\Client is only calling authenticate/addCache when public (but I don't know why)
        public: true
        autowire: true
        autoconfigure: true

If I remove the call

- ['addCache', ['@Cache\Adapter\Redis\RedisCachePool']]

Maybe it's related to the failure I get

                                                                                                                        
 [WARNING] Some commands could not be registered:                                                                       
                                                                                                                        

In getClientService.php line 53:
                      
  Connection refused  

The failure of one calls is denying every calls ? how to solve this ?

[VincentLanglet]

@sonata-project/contributors Any idea why the addCache call is disabling the github authentication ?

@OskarStark should we remove it ?

[jordisala1991]

KnpLabs/php-github-api#947

Maybe this helps?

[VincentLanglet]

Ok I found the reason.

When I correctly configure redis the authenticate call is made.
So it was related to the error

 [WARNING] Some commands could not be registered:                                                                       
                                                                                                                        

In getClientService.php line 53:
                      
  Connection refused  

Is there a way to add the addCache call only if redis server is started, in order to not lose the authenticate call when the redis server is not started ? ^^'

[franmomu]

Suggested change

	$currentRelease = $this->releases->branchLatest($repository, $branch);
	$currentRelease = $this->releases->latestBranch($repository, $branch);

(I think)

[jordisala1991]

The method fetch latest release from given branch, maybe should simply be latestRelease, or more verbose latestBranchRelease

[VincentLanglet]

There is a latest method. It would be weird to add Release to this method and not the latest one.

Here I wanted to say it's the branch's latest release. So branchLatest.
Maybe latestForBranch is more clear ?

[VincentLanglet]

I made the change @franmomu @jordisala1991

[VincentLanglet]

I think this is ready to be merged :)