Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix StringIndexOutOfBoundsException for license #122

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Fix StringIndexOutOfBoundsException for license #122

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 14 additions & 7 deletions get-metrics/src/main/java/org/sonatype/cs/getmetrics/util/ParseReasons.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,8 @@

import org.sonatype.cs.getmetrics.service.PolicyIdsService;
import org.sonatype.cs.getmetrics.service.UtilService;

import java.util.ArrayList;
import java.util.List;

import javax.json.JsonArray;
import javax.json.JsonObject;

Expand Down Expand Up @@ -52,13 +50,15 @@ private static String getCVE(JsonArray reasons) {
return cveList;
}

private static String getLicense(JsonArray reasons) {
public static String getLicense(JsonArray reasons) {
String licenseList = "";
List<String> licenses = new ArrayList<>();

for (JsonObject reason : reasons.getValuesAs(JsonObject.class)) {
String licenseFound = reason.getString("reason");

if (licenseFound.isEmpty()){
continue;
}
String license =
licenseFound.substring(
licenseFound.indexOf("(") + 1, licenseFound.indexOf(")"));
Expand All @@ -69,11 +69,18 @@ private static String getLicense(JsonArray reasons) {
}
}

for (String l : licenses) {
licenseList = l + ":" + licenseList;
if (licenses.size()==0){
return "";
}

licenseList = UtilService.removeLastChar(licenseList);
for (String l : licenses) {
if (licenseList.isEmpty()){
licenseList = l;
}
else{
licenseList = licenseList + ":" +l;
}
}

return licenseList;
}
Expand Down
44 changes: 44 additions & 0 deletions get-metrics/src/test/java/org/sonatype/cs/getmetrics/util/ParseReasonsTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,44 @@
package org.sonatype.cs.getmetrics.util;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.Test;
import javax.json.Json;
import javax.json.JsonArray;

public class ParseReasonsTest {
@Test
void testEmptyLicenseString() {
JsonArray reasons = Json.createArrayBuilder()
.add(Json.createObjectBuilder()
.add("reason", ""))
.build();

String actualReason = ParseReasons.getLicense(reasons);
Assertions.assertEquals("", actualReason);
}

@Test
void testSingleLicenseString() {
JsonArray reasons = Json.createArrayBuilder()
.add(Json.createObjectBuilder()
.add("reason", "(license)"))
.build();

String actualReason = ParseReasons.getLicense(reasons);
Assertions.assertEquals("license", actualReason);
}

@Test
void testMultipltLicenseString() {
JsonArray reasons = Json.createArrayBuilder()
.add(Json.createObjectBuilder()
.add("reason", "(license)")
)
.add(Json.createObjectBuilder()
.add("reason", "(license2)")
)
.build();

String actualReason = ParseReasons.getLicense(reasons);
Assertions.assertEquals("license:license2", actualReason);
}
}
Loading