Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Handle PR commits that don't meet quality requirements #110

Merged
merged 10 commits into from
Sep 18, 2024
Merged

feat: Handle PR commits that don't meet quality requirements #110

merged 10 commits into from
Sep 18, 2024

Conversation

madpah
Copy link
Contributor

@madpah madpah commented Sep 17, 2024 •
edited
Loading

Resolves #109

This PR adds quality checks for all commits on a PR. They include:

  • Confirming Author is set
  • Confirming commits are signed

Feedback will be provided on the PR by the-cla if any commit doesn't pass the quality checks.

Also:

  • upgraded github.com/google/go-github from v42 to v64

@madpah madpah added the enhancement New feature or request label Sep 17, 2024
@madpah madpah requested a review from bhamail September 17, 2024 09:05
@madpah madpah self-assigned this Sep 17, 2024
@madpah madpah marked this pull request as draft September 17, 2024 09:05
@madpah
added tests to prove #109
9e5eeb9 
Signed-off-by: Paul Horton <[email protected]>
@madpah madpah changed the title upgraded github.com/google/go-github from v42 to v64 feat: Handle PR commits that don't meet quality requirements Sep 17, 2024
@madpah madpah marked this pull request as ready for review September 17, 2024 10:17
bhamail
bhamail approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@bhamail bhamail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

FYI, I will likely follow up with a PR to remove a bunch of obsolete build comments in the go source file headers.

github/github_test.go Outdated Show resolved Hide resolved
github/github_test.go Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@madpah
Copy link
Contributor Author

madpah commented Sep 18, 2024

Beautiful work @bhamail! LGTM.

@madpah madpah merged commit b9ba937 into main Sep 18, 2024
7 checks passed
@madpah madpah deleted the feat/handle-poor-quality-commits branch September 18, 2024 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhamail bhamail bhamail approved these changes

Assignees

@madpah madpah

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Handle Commits with no Author or Committer
2 participants
@madpah @bhamail