Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address coments from review of HA proposal #271

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Address coments from review of HA proposal #271

wants to merge 3 commits into from

Conversation

SanjayTh
Copy link
Collaborator

@SanjayTh SanjayTh commented Nov 1, 2022

  • Add Flow sync metadata details and other changes

@SanjayTh
Address coments from review of HA proposal
97b905d 
- Add Flow sync metadata details and other changes
lguohan
lguohan reviewed Nov 1, 2022
View reviewed changes
documentation/high-avail/AMD-Pensando_HA_Proposal.md
/**
* @brief Default result - undefined
*/
SAI_DASH_HA_POLICY_RESULT_NONE,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what does undefined mean here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is to prevent an unset value taking on a valid value by default and should be explicitly set to one of the other values. This value should not seen on the wire

chrispsommers
chrispsommers requested changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@chrispsommers chrispsommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan left review comments

@chrispsommers chrispsommers chrispsommers approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SanjayTh @lguohan @chrispsommers