-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dash-p4] Add tunnel member table and tunnel next hop table. #622
Conversation
hi @prsunny , here is the preview of the tunnel member and next hop change. please let me know, if you have any concerns. The API should be ok, and I will get the P4 part a bit more stable in the meantime. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
hi @mukeshmv , the tunnel design follows exactly the same pattern as the current SAI next hop group and next hop design. If preallocation is required, we can ensure the tunnel next hops are all created before bind the tunnel to any mappings. And after that, the next hop list will not be change. This should solve the problem. However, we do have case there tunnel next hops being changed, say a destination being removed. Without certain support, this can fundamentally break certain scenarios. So let's touch base offline and see how to get this supported. |
Actually, after second thought, this might be related to the hash distribution thing, not the actual element count. Adding a size should help. Yea, we can add that. I will push a new PR late today. |
Looks ready to merge |
@prsunny Can you please specify the scale parameters for these objects in the HLD |
@mukeshmv , the following are the scale we are thinking:
Will update the sonic-hld for this scale numbers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
To support the ECMP group in the tunnel, this change adds the tunnel member and tunnel next hop tables using the same way as how next hop group works today in SAI.
The detailed design is following the HLD defined here: https://github.com/sonic-net/DASH/blob/main/documentation/private-link-service/private-link-service.md.