-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define table size per scaling test #644
Conversation
dash-pipeline/bmv2/defines.h
Outdated
#ifndef _DASH_DEFINES_H_ | ||
#define _DASH_DEFINES_H_ | ||
|
||
#ifdef TABLE_FULL_SCALE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be better to use TABLE_BABY_HERO_SCALE
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use TABLE_HERO_SCALE/TABLE_BABY_HERO_SCALE for hero/baby-hero respectively.
thanks a lot Junhua for making this change! |
6fe1873
to
0740ac2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for getting the numbers and macro align with the spec!
@mgheorghe , would you like to take another look? |
This pull request adds a new header file
defines.h
for constants definitions. It defines different table sizes for outbound routing and ca_to_pa mapping according to hero-implementation-details.The hardcoded table sizes of outbound routing and ca_to_pa mapping, whose size 4M and 8M respectively (from #592) take up too much memory by default. This memory pressure could make low-RAM KVM DPU crash and be unusable with sonic mgmt test.
The below shows the dash pipeline memory usage of the container
simple_switch
with different scale number of routing and mapping.