Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patch fix to ignore dup nh in netlink msg #16385

Merged
merged 1 commit into from
Sep 2, 2023

Conversation

arlakshm
Copy link
Contributor

@arlakshm arlakshm commented Sep 1, 2023

Why I did it

Fixes #15803

In SONiC chassis, routes have recursive nexthop resolution when the routes are learnt from remote linecard.
In some cases after recursive nexthop resolution the number of nexthop for a route could reach 256.
Zebra ran out of space when filling up 256 nexthops which causes zebra crash.

Work item tracking
  • Microsoft ADO (24997365):

How I did it

Create a patch to port FRRouting/frr#14096 which has change to ignore duplicate nexthop when filling up fpm message

The Fix was commit in this PR in master #16275. This PR is port of the fix to 202205

How to verify it

Testing on voq chassis

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

Signed-off-by: Arvindsrinivasan Lakshmi Narasimhan <[email protected]>
@arlakshm arlakshm requested a review from lguohan as a code owner September 1, 2023 18:58
@arlakshm arlakshm requested review from gechiang and yxieca September 1, 2023 18:58
@arlakshm
Copy link
Contributor Author

arlakshm commented Sep 1, 2023

@mlok-nokia @saksarav-nokia for viz..

@mlok-nokia
Copy link
Contributor

It looks good to me.

Copy link
Collaborator

@gechiang gechiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gechiang gechiang requested a review from rlhui September 2, 2023 02:32
@rlhui rlhui merged commit 18fb27b into sonic-net:202205 Sep 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants