-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[202311][FRR]Adding fix for memory leak seen with BGP community #18606
Conversation
@StormLiangMS please help to review. Tests will be completed very soon and we will to merge once done |
hi @lipxu @jimmyzhai could you help to take review this PR? |
Have you verified with 202311 image? PR test has no gating for this one. @liat-grozovik |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @StormLiangMS . There is no test to verify. 202305 and 202311 have identical FRR. @lipxu verified the fixes in 202305. In my opinion the testing in 202305 is sufficient. I would also recommend adding a test to sonic-mgmt to cover this scenario. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
oops, 202311 should be Ying to decide to take or not, my bad. @yxieca |
Porting PR #18272 to 202311.
Why I did it
Porting fix for FRRouting/frr#15459
Adding patch for PR FRRouting/frr#15466
Work item tracking
How I did it
Ported the fix FRRouting/frr#15466 to 8.5.1
How to verify it
Running the test_stress_route and ensure no memory leak
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)