[chassis][database-chassis] Fix the database-chassis service fails to start issue #20824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… start issue Signed-off-by: mlok <[email protected]>
|
@arlakshm and @judyjoseph This PR fixes the database-chassis.service fails to start on SUP issue. Please review it |
FengPan-Frank
approved these changes
Nov 18, 2024
|
/azpw ms_conflict |
@rlhui @mlok-nokia This fix has already been incorporated into master branch , we can close this PR for now. |
qiluo-msft
approved these changes
Nov 28, 2024
|
Close since the issue has been fixed by PR #1894 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
On Master branch only, database-chassis service failed to start on SUP. PR #19016 introduces the redis_bmp process to the database container. redis_bmp.socket is only available after database container is created. database-chassis container is created and started before the database. Trying to chgrp/chamod on file redis_bmp.sock will be result of access failure during database-chassis creation. Fixes #20715
Work item tracking
How I did it
Modify the docker_image_ctl.j2 by moving the "chgrp -f redis $REDIS_BMP_SOCK && chmod -f 0760 $REDIS_BMP_SOCK" related code to the "database" section to avoid the database-chassis try to modify the permission of redis_bmp.sock
How to verify it
Reboot SUP with the new image. database-chassis.service should be started without any issue.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)