Go Code format checker and formatter #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faraazbrcm
force-pushed
the
code_formatting
branch
16 times, most recently
from
39647af to
a23b8a3
Compare
anand-kumar-subramanian
requested review from
kwangsuk,
seiferteric,
liuh-80 and
ganglyu
sachinholla
reviewed
Jan 18, 2024
faraazbrcm
force-pushed
the
code_formatting
branch
from
a23b8a3 to
0d25947
Compare
sachinholla
approved these changes
Jan 18, 2024
kwangsuk
approved these changes
Jan 18, 2024
anand-kumar-subramanian
force-pushed
the
code_formatting
branch
from
0d25947 to
ea00a3c
Compare
faraazbrcm
force-pushed
the
code_formatting
branch
3 times, most recently
from
e61ae37 to
0c7cf59
Compare
|
@faraazbrcm thank you for putting up this PR, do you have the time to move it forward and submit? We think the formatting cleanup and build check would be very helpful to have. |
faraazbrcm
force-pushed
the
code_formatting
branch
from
0c7cf59 to
faaa1e9
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
faraazbrcm
force-pushed
the
code_formatting
branch
from
faaa1e9 to
465e26f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
faraazbrcm
force-pushed
the
code_formatting
branch
from
465e26f to
ff84216
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
faraazbrcm
force-pushed
the
code_formatting
branch
from
ff84216 to
89e163d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
faraazbrcm
force-pushed
the
code_formatting
branch
from
89e163d to
e36784d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Also formatted the files which dont adhere to go formats. Build will fail if there exists any formatting issue. Formatting is supported for bookworm as well.
faraazbrcm
force-pushed
the
code_formatting
branch
from
e36784d to
fb1690c
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
anand-kumar-subramanian
approved these changes
Feb 12, 2025
Its merged now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also formatted the files which dont adhere to go formats. Build will fail if there exists any formatting issue.
Formatting is supported for bookworm as well.
Why I did it
This was done to make the code readable and organised as per Golang standards
How I did it
I execute gofmt tool as part of build step and fail the build in case of formatting issues
How to verify it
build has to go through. no manual verification is required.