You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telemetry.go currently is bypassing UT and diff code coverage checks.
What this PR is doing:
No longer uses a global config in order to make flag parsing and other goroutine functions easier to test by passing local config. Instead uses a local config struct TelemetryConfig for parsing and is created within setupFlags which parses flags passed by cmd line arguments.
Logic for creating gnmi server and calling Serve() is now done inside of a goroutine such that it allows the main thread to support concurrent tasks in the future.
Call server stop after Serve() returns
MD5 checksum is replaced with SHA512 checksum as per semgrep findings. MD5 checksum is no longer considered secure as "MD5 hash algorithm is considered insecure. MD5 is not collision resistant and is therefore not suitable as a cryptographic signature."
Enable UT and code coverage for telemetry.go
How I did it
Removed global config, changed md5 checksum semgrep issue, enabled UT and CC checks for telemetry.go
How to verify it
Pipeline/UT
Which release branch to backport (provide reason below if selected)
201811
201911
202006
202012
202106
202111
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)
The reason will be displayed to describe this comment to others. Learn more.
This function performs two tasks: it computes the checksum of a given file using the SHA-512 algorithm and it logs a message to the system logger with the file name and the checksum value. Therefore, the function name validateSHA512 is misleading, as it implies that the function only validate checksum.
How long does it take to calculate SHA512 checksum? Much slower?
It seems that our pr checker does not cover this file, would you please add unit test and check coverage?
How long does it take to calculate SHA512 checksum? Much slower? It seems that our pr checker does not cover this file, would you please add unit test and check coverage?
Added UT and code coverage for telemetry.go. Since we are computing SHA512 checksum of a cert file (~4KB for private key), we can expect it to take only a couple of MS.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
zbud-msft
changed the title
Why I did it
telemetry.go currently is bypassing UT and diff code coverage checks.
What this PR is doing:
How I did it
Removed global config, changed md5 checksum semgrep issue, enabled UT and CC checks for telemetry.go
How to verify it
Pipeline/UT
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)