Update GNMI path schema #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiluo-msft
reviewed
Mar 6, 2024
sonic_data_client/mixed_db_client.go
Outdated
| // Skip first elem | ||
| fullPath.Elem = elems[1:] | ||
| // Skip first two elem | ||
| // New GNMI path schema, /CONFIG_DB/localhost/PORT |
There was a problem hiding this comment.
Do not use "New" in comment. It will loss meaning in long run. Audience have no idea of "Old" when looking at the latest code, if this will be day-one behavior in production. #Closed
wen587
reviewed
Mar 7, 2024
| @@ -8,16 +8,16 @@ | |||
| test_data_update_normal = [ | |||
| [ | |||
| { | |||
| 'update_path': '/sonic-db:APPL_DB/DASH_QOS', | |||
| 'get_path': '/sonic-db:APPL_DB/_DASH_QOS', | |||
| 'update_path': '/sonic-db:APPL_DB/localhost/DASH_QOS', | |||
There was a problem hiding this comment.
Do we also use localhost in APPL_DB? I remember the localhost is only used in CONFIG_DB.
There was a problem hiding this comment.
GNMI needs to support multi-asic for APPL_DB, so I use the same schema for APPL_DB.
wen587
approved these changes
Mar 7, 2024
qiluo-msft
approved these changes
Mar 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
We need to update sonic-gnmi to support new GNMI path schema.
HLD PR: sonic-net/SONiC#1625
How I did it
I add a new element in GNMI path to support database instance.
The second element is used for target database instance, and it's localhost by default.
How to verify it
Run unit test for sonic-gnmi.
Run end to end test for dash and gnmi.
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)