Add ImageService.set_next_boot for GNOI Activate OS. #207
+75
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
host_modules/image_service.py:180
- The error message handling might miss relevant error messages that do not contain the word 'Error'. Consider capturing all lines from stderr.
if "Error" in line:
|
/azp run |
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Could you provide some sample test result in PR description? |
| logger.info("Setting the next boot image to {}".format(image)) | ||
| cmd = ["/usr/local/bin/sonic-installer", "set-next-boot", image] | ||
| result = subprocess.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) | ||
| msg = "" |
There was a problem hiding this comment.
There is no successful message?
| result = subprocess.run(cmd, stdout=subprocess.PIPE, stderr=subprocess.PIPE) | ||
| msg = "" | ||
| if result.returncode: | ||
| msg = result.stderr.decode() |
There was a problem hiding this comment.
Also, recommend to log error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a method set_next_boot to the ImageService interface.
This method will set the next boot image to the specified image.
This is used to implement GNOI OS.Activate.