Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip passw_hardening script due to Issue #13582 #12244

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vperumal
Copy link
Contributor

@vperumal vperumal commented Mar 30, 2024

Description of PR

Skip the script due to Issue #13582. Command currently not supported multi-asic platforms
sonic-net/sonic-buildimage#13582. Another tracker for this: sonic-net/sonic-buildimage#18417

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311

Approach

What is the motivation for this PR?

Script fails due to sonic-net/sonic-buildimage#13582

How did you do it?

How did you verify/test it?

Verified it on a multi-asic platform

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@vperumal
Copy link
Contributor Author

FYI @abdosi @rajendrat

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

  • generated xml file: /run_logs/9983_reruns/passw_hardening_2024-03-30-17-08-45.xml -
    =========================== short test summary info ============================
    SKIPPED [30] passw_hardening/test_passw_hardening.py: Skip the script due to Issue enable test_link_down on t0 and t1 devices #13582. Command currently not supported multi-asic platforms
    ======================= 30 skipped, 1 warning in 19.09s ========================

@abdosi
Copy link
Contributor

abdosi commented Apr 27, 2024

@vperumal let's mark them xfail so easy to track when to enable them back once the root issue is fixed.

@vperumal
Copy link
Contributor Author

vperumal commented May 1, 2024

Done @abdosi as per your comments, kindly approve and merge

@vperumal
Copy link
Contributor Author

@abdosi - Can you please approve and merge - This issue is still present in 202405 images too

@vperumal
Copy link
Contributor Author

FYI @yejianquan

@yejianquan
Copy link
Collaborator

The failure is because of the None lane value in multi-asic devices,
In our internal buildimage repo, we have this fix and it works
image
@arlakshm what's the plan to include the fix into the github repo?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants