Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip test_bgp_suppress_fib in 202405 release #14877

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

AnantKishorSharma
Copy link
Contributor

Description of PR

Conflict Resolution PR for #14628

As the required SW changes are not available in 202405 we should skip test_bgp_suppress_fib for 202405

"We should not be taking this change in 202405 as we don't have the required memory enhancements that are part of master only. From 202411 we will have fib suppression feature"(Revert "Remove suppress-fib-pending CLI and make route_check.py check suppress-fib in BGP configuration" by dgsudharsan · Pull Request #3477 · sonic-net/sonic-utilities ).

Summary:
Fixes ##14381

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 201911
  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Skip the test as the functionality is not available in the release 202405

How did you do it?

Skip the test for 202405 release

How did you verify/test it?

Test skipped

------ generated xml file: /run_logs/ananshar/bgp/test_bgp_suppress_fib_2024-09-18-06-43-54.xml ------

--------------------------------------- live log sessionfinish ---------------------------------------
06:44:05 __init__.pytest_terminal_summary         L0067 INFO   | Can not get Allure report URL. Please check logs
====================================== short test summary info =======================================
SKIPPED [2] bgp/test_bgp_suppress_fib.py:717: Not supported before release 202411.
SKIPPED [5] bgp/test_bgp_suppress_fib.py: Not supported before release 202411.
=================================== 7 skipped, 1 warning in 9.53s ====================================

Any platform specific information?

Generic issue

Supported testbed topology if it's a new test case?

NA

Documentation

NA

Copy link
Contributor

@wsycqyz wsycqyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lğtm

@StormLiangMS StormLiangMS merged commit 6c5dda9 into sonic-net:202405 Oct 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants