Disable proxy for POST requests to PTF #15067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi @kevinskwang @StormLiangMS, do we need anything else to get this merged and backported to 202405? |
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 15, 2024
What is the motivation for this PR? Tests that make HTTP POST requests to PTFIP:exabgpPort for bgp updates were failing when proxy variables were set in the environment (gateway timeout 504). Workaround had been to unset these variables before starting the tests. This PR fixes the test scripts such that they don't use the env proxy when making such HTTP requests. How did you do it? Explicitly set the proxies to None when making post requests to ignore the corresponding environment variables. Precedent for this change exists: https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/library/announce_routes.py#L163 How did you verify/test it? Following tests passed with the change despite the presence of proxy variables in the sonic-mgmt container environment (tested on DUT Cisco 8101): test_bgp_update_timer.py test_bgp_sentinel.py test_bgp_bbr.py test_bgp_speaker.py test_route_flap.py test_bgp_dual_asn.py
|
@AkeelAli PR conflicts with 202405 branch |
8 tasks
yejianquan
pushed a commit
that referenced
this pull request
Nov 21, 2024
Description of PR Summary: Resolves conflict for #15067 into 202405 co-authorized by: [email protected]
yutongzhang-microsoft
pushed a commit
to yutongzhang-microsoft/sonic-mgmt
that referenced
this pull request
Nov 21, 2024
What is the motivation for this PR? Tests that make HTTP POST requests to PTFIP:exabgpPort for bgp updates were failing when proxy variables were set in the environment (gateway timeout 504). Workaround had been to unset these variables before starting the tests. This PR fixes the test scripts such that they don't use the env proxy when making such HTTP requests. How did you do it? Explicitly set the proxies to None when making post requests to ignore the corresponding environment variables. Precedent for this change exists: https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/library/announce_routes.py#L163 How did you verify/test it? Following tests passed with the change despite the presence of proxy variables in the sonic-mgmt container environment (tested on DUT Cisco 8101): test_bgp_update_timer.py test_bgp_sentinel.py test_bgp_bbr.py test_bgp_speaker.py test_route_flap.py test_bgp_dual_asn.py
bingwang-ms
added
Included in 202405 branch
and removed
Approved for 202405 branch
Cherry Pick Conflict_202405
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary: Ensures no proxy is used when sending HTTP POST requests to PTF in bgp tests even if proxy variables are set in the environment.
Type of change
Back port request
Approach
What is the motivation for this PR?
Tests that make HTTP POST requests to PTFIP:exabgpPort for bgp updates were failing when proxy variables were set in the environment (gateway timeout 504). Workaround had been to unset these variables before starting the tests. This PR fixes the test scripts such that they don't use the env proxy when making such HTTP requests.
How did you do it?
Explicitly set the proxies to
Nonewhen making post requests to ignore the corresponding environment variables.Precedent for this change exists: https://github.com/sonic-net/sonic-mgmt/blob/master/ansible/library/announce_routes.py#L163
How did you verify/test it?
Following tests passed with the change despite the presence of proxy variables in the sonic-mgmt container environment (tested on DUT Cisco 8101):
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation