[VOQ-Chassis] bgp-queue: skip internal nbrs for voq-chassis #15492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arlakshm
approved these changes
Nov 28, 2024
7 tasks
sreejithsreekumaran
pushed a commit
to sreejithsreekumaran/sonic-mgmt
that referenced
this pull request
Nov 29, 2024
…t#15492) Summary: Fixes # (issue) In addition to skipping internal neighbors belong to peer-group "INTERNAL_PEER_V4", "INTERNAL_PEER_V6" by Fix only test eBGP neighbors for test_bgp_queues sonic-net#14310, skip VOQ_CHASSIS peer group internal neighbors as well for testing test_bgp_queue This change can be removed once BRCM fixes iBGP traffic over queue 7 and as per discussion it would be available in 202411. Approach What is the motivation for this PR? 'test_bgp_queue' tests fail for VOQ-CHASSIS, when the interface selected is 'Ethernet-IB0'. How did you do it? In addition to the current internal peer group, add 'VOQ_CHASSIS' peer groups as well for skipping internal neighbors as part of the test. How did you verify/test it? Ran 'test_bgp_queue' tests on T2 VOQ-Chassis and made sure the expected tests are passing.
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Nov 30, 2024
…t#15492) Summary: Fixes # (issue) In addition to skipping internal neighbors belong to peer-group "INTERNAL_PEER_V4", "INTERNAL_PEER_V6" by Fix only test eBGP neighbors for test_bgp_queues sonic-net#14310, skip VOQ_CHASSIS peer group internal neighbors as well for testing test_bgp_queue This change can be removed once BRCM fixes iBGP traffic over queue 7 and as per discussion it would be available in 202411. Approach What is the motivation for this PR? 'test_bgp_queue' tests fail for VOQ-CHASSIS, when the interface selected is 'Ethernet-IB0'. How did you do it? In addition to the current internal peer group, add 'VOQ_CHASSIS' peer groups as well for skipping internal neighbors as part of the test. How did you verify/test it? Ran 'test_bgp_queue' tests on T2 VOQ-Chassis and made sure the expected tests are passing.
|
Cherry-pick PR to 202405: #15817 |
8 tasks
mssonicbld
pushed a commit
that referenced
this pull request
Nov 30, 2024
Summary: Fixes # (issue) In addition to skipping internal neighbors belong to peer-group "INTERNAL_PEER_V4", "INTERNAL_PEER_V6" by Fix only test eBGP neighbors for test_bgp_queues #14310, skip VOQ_CHASSIS peer group internal neighbors as well for testing test_bgp_queue This change can be removed once BRCM fixes iBGP traffic over queue 7 and as per discussion it would be available in 202411. Approach What is the motivation for this PR? 'test_bgp_queue' tests fail for VOQ-CHASSIS, when the interface selected is 'Ethernet-IB0'. How did you do it? In addition to the current internal peer group, add 'VOQ_CHASSIS' peer groups as well for skipping internal neighbors as part of the test. How did you verify/test it? Ran 'test_bgp_queue' tests on T2 VOQ-Chassis and made sure the expected tests are passing.
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation