[P4_Symbolic] Extend IR proto and translation to support parsers. #755
+300
−64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keyword Check:
~/sonic-buildimage/src/sonic-p4rt/sonic-pins$ ~/tools/keyword_checks.sh .
Keyword check Passed.
Build Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel build $BAZEL_BUILD_OPTS ...
INFO: Build options --copt, --cxxopt, --host_copt, and 1 more have changed, discarding analysis cache.
INFO: Analyzed 594 targets (0 packages loaded, 22508 targets configured).
INFO: Found 594 targets...
INFO: From Compiling src/google/protobuf/generated_message_tctable_lite.cc:
In file included from bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/generated_message_tctable_decl.h:45,
from external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:37:
bazel-out/k8-opt-exec-2B5CBBC6/bin/external/com_google_protobuf/src/google/protobuf/_virtual_includes/protobuf_lite/google/protobuf/parse_context.h:1150:1: warning: 'always_inline' function might not be inlinable [-Wattributes]
1150 | ParseContext::ParseLengthDelimitedInlined(const char* ptr, const Func& func) {
| ^~~~~~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
871 | PROTOBUF_ALWAYS_INLINE const char* TcParser::FastVarintS1(
| ^~~~~~~~
external/com_google_protobuf/src/google/protobuf/generated_message_tctable_lite.cc:871:36: warning: 'always_inline' function might not be inlinable [-Wattributes]
INFO: From Compiling src/google/protobuf/compiler/retention.cc:
external/com_google_protobuf/src/google/protobuf/compiler/retention.cc: In function 'void google::protobuf::compiler::{anonymous}::StripSourceCodeInfo(std::vector<std::vector >&, google::protobuf::SourceCodeInfo&)':
external/com_google_protobuf/src/google/protobuf/compiler/retention.cc:216:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vectorgoogle::protobuf::SourceCodeInfo_Location*::size_type' {aka 'long unsigned int'} [-Wsign-compare]
216 | for (int i = 0; i < old_locations.size(); ++i) {
| ~~^~~~~~~~~~~~~~~~~~~~~~
INFO: From Compiling src/google/protobuf/generated_message_tctable_lite.cc [for host]:
INFO: From Compiling p4_symbolic/symbolic/table.cc [for host]:
p4_symbolic/symbolic/table.cc: In function 'std::vector<std::pair<int, pdpi::IrTableEntry> > p4_symbolic::symbolic::table::{anonymous}::SortEntries(const p4_symbolic::ir::Table&, const std::vectorpdpi::IrTableEntry&)':
p4_symbolic/symbolic/table.cc:115:21: warning: comparison of integer expressions of different signedness: 'int' and 'std::vectorpdpi::IrTableEntry::size_type' {aka 'long unsigned int'} [-Wsign-compare]
115 | for (int i = 0; i < entries.size(); i++) {
| ~~^~~~~~~~~~~~~~~~
INFO: From Compiling p4_symbolic/symbolic/util.cc [for host]:
p4_symbolic/symbolic/util.cc:34:6: warning: 'bool p4_symbolic::symbolic::util::{anonymous}::Z3BooltoBool(Z3_lbool)' defined but not used [-Wunused-function]
34 | bool Z3BooltoBool(Z3_lbool z3_bool) {
| ^~~~~~~~~~~~
INFO: Elapsed time: 1196.058s, Critical Path: 309.65s
INFO: 2583 processes: 3 internal, 2580 linux-sandbox.
INFO: Build completed successfully, 2583 total actions
Test Result:
/sonic/src/sonic-p4rt/sonic-pins$ bazel test $BAZEL_BUILD_OPTS --cache_test_results=no ...
INFO: Analyzed 594 targets (0 packages loaded, 351 targets configured).
INFO: Found 399 targets and 195 test targets...
INFO: Elapsed time: 182.290s, Critical Path: 120.35s
INFO: 249 processes: 294 linux-sandbox, 18 local.
INFO: Build completed successfully, 249 total actions
//dvaas:port_id_map_test PASSED in 0.7s
//dvaas:test_vector_stats_diff_test PASSED in 0.3s
//dvaas:test_vector_stats_test PASSED in 0.0s
//dvaas:test_vector_test PASSED in 1.0s
//sai_p4/instantiations/google:middleblock_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google:sai_nonstandard_platforms_build_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_nonstandard_platforms_cc_test PASSED in 0.7s
//sai_p4/instantiations/google:sai_p4info_fetcher_test PASSED in 0.8s
//sai_p4/instantiations/google:sai_p4info_test PASSED in 1.5s
//sai_p4/instantiations/google:sai_pd_proto_test PASSED in 0.0s
//sai_p4/instantiations/google:sai_pd_util_test PASSED in 1.8s
//sai_p4/instantiations/google:tor_p4info_up_to_date_test PASSED in 1.7s
//sai_p4/instantiations/google:union_p4info_up_to_date_test PASSED in 0.4s
//sai_p4/instantiations/google:wbb_p4info_up_to_date_test PASSED in 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_helper_test PASSED in 2.6s
//sai_p4/instantiations/google/test_tools:test_entries_test PASSED in 1.1s
//sai_p4/instantiations/google/tests:p4_fuzzer_integration_test PASSED in 3.6s
//sai_p4/tools:p4info_tools_test PASSED in 0.6s
//sai_p4/tools:packetio_tools_test PASSED in 1.1s
//tests:thinkit_gnmi_interface_util_tests PASSED in 1.0s
//tests/qos:gnmi_parsers_test PASSED in 0.1s
//tests/qos:gnmi_parsers_test_runner PASSED in 0.2s
//thinkit:bazel_test_environment_test PASSED in 0.7s
//thinkit:generic_testbed_test PASSED in 1.0s
//thinkit:mock_control_device_test PASSED in 1.1s
//thinkit:mock_generic_testbed_test PASSED in 0.8s
//thinkit:mock_mirror_testbed_test PASSED in 0.9s
//thinkit:mock_ssh_client_test PASSED in 0.1s
//thinkit:mock_switch_test PASSED in 1.7s
//thinkit:mock_test_environment_test PASSED in 0.1s
//thinkit:switch_test PASSED in 1.1s
//sai_p4/instantiations/google/tests:p4_constraints_integration_test PASSED in 0.9s
Stats over 5 runs: max = 0.9s, min = 0.7s, avg = 0.8s, dev = 0.1s
//sai_p4/instantiations/google/test_tools:table_entry_generator_test PASSED in 48.8s
Stats over 50 runs: max = 48.8s, min = 0.8s, avg = 4.6s, dev = 11.9s
Executed 195 out of 195 tests: 195 tests pass.
INFO: Build completed successfully, 249 total actions