Fix SNMP QoS MIB only shows queues 1-6 on platform with 8 ucast/4 mcast queues #329
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Fix for sonic-net/sonic-buildimage#20033)
- What I did
On some platforms (specifically Broadcom TH4/TH5), there are not an equal number of unicast and multicast queues. Previous code would assume that there was an even number, causing missing snmp counters.
Instead of wrapping multicast values based on maximum number of queues, after this change the wrap is based on number of priority groups.
- How I did it
Modified code to use STATE_DB "max_priority_groups" instead of "max_queues".
- How to verify it
Verified on J2C/TH4/TH5 based platforms.
snmpwalk shows 8 queues, first 4 show multicast counters:
- Description for the changelog
Modify SNMP QoS MIB to wrap multicast counters based on maximum number of priority groups.