Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix config save error for non-hash key. #485

Merged
merged 2 commits into from
May 11, 2021

Conversation

mint570
Copy link
Contributor

@mint570 mint570 commented Apr 29, 2021

This is a cleanup for pr#465.
@mint570
Copy link
Contributor Author

mint570 commented May 10, 2021

Hi @qiluo-msft, could you please take a look at this pr?

@@ -401,7 +401,8 @@ int ConfigDBPipeConnector_Native::_get_config(DBConnector& client, RedisTransact
pipe.multi();
for (auto const& key: keys)
{
if (key == INIT_INDICATOR)
size_t pos = key.find(m_table_name_separator);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pos

The fix looks good. Could you add unit testcase?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ghost
Copy link

ghost commented May 11, 2021

CLA assistant check
All CLA requirements met.

@qiluo-msft qiluo-msft merged commit 73d0e2d into sonic-net:master May 11, 2021
@mint570 mint570 deleted the fix_config_save branch May 12, 2021 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants