-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dash] Handle FC update for existing ENI objects #3373
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vkarri <[email protected]>
oleksandrivantsiv
approved these changes
Nov 15, 2024
/azpw run Azure.sonic-swss |
/AzurePipelines run Azure.sonic-swss |
Azure Pipelines successfully started running 1 pipeline(s). |
@prsunny, @theasianpianist Please review this PR |
prsunny
approved these changes
Nov 26, 2024
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
Why I did When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's. What I did Fix the flow.
bradh352
pushed a commit
to bradh352/sonic-swss
that referenced
this pull request
Dec 4, 2024
Why I did When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's. What I did Fix the flow.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
Why I did When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's. What I did Fix the flow.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
Why I did When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's. What I did Fix the flow.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Jan 27, 2025
Why I did When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's. What I did Fix the flow.
shiraez
pushed a commit
to Marvell-switching/sonic-swss
that referenced
this pull request
Feb 17, 2025
Why I did When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's. What I did Fix the flow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did
When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.
What I did
Fix the flow.
How I verified it
Create ENI, By default FC is enabled on DPU
Disable ENI, this removes FC
Re-enable FC,
Details if related