Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dash] Handle FC update for existing ENI objects #3373

Merged
merged 3 commits into from
Nov 26, 2024

Conversation

vivekrnv
Copy link
Contributor

@vivekrnv vivekrnv commented Nov 15, 2024

Why I did

When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.

What I did

Fix the flow.

How I verified it

Create ENI, By default FC is enabled on DPU

2024 Nov 13 00:53:05.218187 sonic INFO swss#orchagent: :- doTask: Registering FC for ENI: 497f23d7-f0ac-4c99-a98f-59b470e8c7bd, id oid:0x7008000000020
root@sonic:/home/admin# sonic-db-cli COUNTERS_DB hgetall COUNTERS:oid:0x7008000000020
{ 'SAI_ENI_STAT_OUTBOUND_RX_PACKETS': '21', ……..}
root@sonic:/home/admin# sonic-db-cli COUNTERS_DB HGETALL "COUNTERS_ENI_NAME_MAP"
{'497f23d7-f0ac-4c99-a98f-59b470e8c7bd': 'oid:0x7008000000020'}

Disable ENI, this removes FC

root@sonic:/home/admin# counterpoll eni disable
2024 Nov 13 00:54:58.667654 sonic INFO swss#orchagent: :- removeEniFromFC: Unregistering FC for 497f23d7-f0ac-4c99-a98f-59b470e8c7bd, id: oid:0x7008000000020
root@sonic:/home/admin# sonic-db-cli COUNTERS_DB HGETALL "COUNTERS_ENI_NAME_MAP"
{}

Re-enable FC,

root@sonic:/home/admin# counterpoll eni enable
2024 Nov 13 00:55:30.715809 sonic INFO swss#orchagent: :- doTask: Registering FC for ENI: 497f23d7-f0ac-4c99-a98f-59b470e8c7bd, id oid:0x7008000000020
root@sonic:/home/admin# sonic-db-cli COUNTERS_DB HGETALL "COUNTERS_ENI_NAME_MAP"
{'497f23d7-f0ac-4c99-a98f-59b470e8c7bd': 'oid:0x7008000000020'}

<Send 10 pkts>
testutils.send(ptfadapter, dash_pl_config[LOCAL_PTF_INTF], pkt, 10)
root@sonic:/home/admin# sonic-db-cli COUNTERS_DB hgetall COUNTERS:oid:0x7008000000020
{'SAI_ENI_STAT_OUTBOUND_RX_PACKETS': '31'}

Details if related

@vivekrnv vivekrnv requested a review from prsunny as a code owner November 15, 2024 17:51
@vivekrnv
Copy link
Contributor Author

/azpw run Azure.sonic-swss

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-swss

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vivekrnv
Copy link
Contributor Author

@prsunny, @theasianpianist Please review this PR

@prsunny prsunny merged commit a8c358f into sonic-net:master Nov 26, 2024
17 checks passed
bradh352 pushed a commit to bradh352/sonic-swss that referenced this pull request Dec 4, 2024
Why I did
When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.

What I did
Fix the flow.
bradh352 pushed a commit to bradh352/sonic-swss that referenced this pull request Dec 4, 2024
Why I did
When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.

What I did
Fix the flow.
divyachandralekha pushed a commit to divyachandralekha/sonic-swss that referenced this pull request Dec 12, 2024
Why I did
When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.

What I did
Fix the flow.
divyachandralekha pushed a commit to divyachandralekha/sonic-swss that referenced this pull request Dec 12, 2024
Why I did
When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.

What I did
Fix the flow.
stepanblyschak pushed a commit to stepanblyschak/sonic-swss that referenced this pull request Jan 27, 2025
Why I did
When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.

What I did
Fix the flow.
shiraez pushed a commit to Marvell-switching/sonic-swss that referenced this pull request Feb 17, 2025
Why I did
When FC is enabled after being disabled, FlexCounters are not installed for existing ENI's.

What I did
Fix the flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants