[SmartSwitch] Extend reboot script for rebooting SmartSwitch #3566
+572
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vvolam
force-pushed
the
ss-reboot
branch
2 times, most recently
from
460146c
to
c72fbc0
Compare
vvolam
force-pushed
the
ss-reboot
branch
3 times, most recently
from
8746356
to
d6fc624
Compare
gpunathilell
reviewed
Nov 1, 2024
vvolam
changed the title
prgeor
reviewed
Nov 5, 2024
Increase code coverage as well
prgeor
reviewed
Nov 27, 2024
prgeor
reviewed
Nov 27, 2024
prgeor
reviewed
Nov 27, 2024
1. Move module base functions to utilties_common/module_base.py 2. Use load_platform_chassis from utilities_common/util_base.py 3. Write unit tests accordingly
utilities_common/module_base.py
Outdated
| Returns: | ||
| bool: True if the reboot command was successfully sent, False otherwise. | ||
| """ | ||
| module_index = util.try_get(self.platform_chassis.get_module_index, module_name, default=INVALID_MODULE_INDEX) |
There was a problem hiding this comment.
The current util_base.py try_get implemntation does not accept function arguments, may need to be modified
prgeor
reviewed
Nov 27, 2024
prgeor
reviewed
Nov 27, 2024
|
For reboot, is it also possible to check the CONFIG_DB entry for the admin state for the DPUs? if the CONFIG_DB entry is missing or set to down, then we do not need to reboot the DPUs at all |
Co-authored-by: Gagan Punathil Ellath <[email protected]>
Co-authored-by: Gagan Punathil Ellath <[email protected]>
Instantiate ModuleHelper() before calling its functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Extended reboot script for SmartSwitch cases to reboot entire SmartSwitch or a specific DPU
How I did it
Implemented changes according to https://github.com/sonic-net/SONiC/blob/605c3a56ac2717dbbb638433e7bb13054fc05a31/doc/smart-switch/reboot/reboot-hld.md
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)