Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate interface name length in CLI #3580

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

stepanblyschak
Copy link
Contributor

@stepanblyschak stepanblyschak commented Oct 21, 2024

This PR is accompanied by sonic-net/sonic-swss-common#931 and sonic-net/sonic-buildimage#20108

What I did

Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions.

How I did it

Add validation checks in the relevant config functions for the following interface types:

vxlan
vlan
vrf
loopback
subinterface
portchannel

How to verify it

UT tests added

Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)

@stepanblyschak stepanblyschak changed the title Master validate interface name length new Validate interface name length in CLI Oct 21, 2024
@qiluo-msft
Copy link
Contributor

/azp run Azure.sonic-utilities

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stepanblyschak stepanblyschak force-pushed the master_validate_interface_name_length-new branch from dc09bad to 6be74f7 Compare October 30, 2024 16:13
@stepanblyschak
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stepanblyschak
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stepanblyschak
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@stepanblyschak
Copy link
Contributor Author

Some git failure:

fatal: couldn't find remote ref refs/pull/3580/merge
##[warning]Git fetch failed with exit code 128, back off 2.513 seconds before retry.
git --config-env=http.extraheader=env_var_http.extraheader fetch --force --tags --prune --prune-tags --progress --no-recurse-submodules origin   +refs/heads/*:refs/remotes/origin/* +refs/pull/3580/merge:refs/remotes/pull/3580/merge
fatal: couldn't find remote ref refs/pull/3580/merge
##[warning]Git fetch failed with exit code 128, back off 5.95 seconds before retry.
git --config-env=http.extraheader=env_var_http.extraheader fetch --force --tags --prune --prune-tags --progress --no-recurse-submodules origin   +refs/heads/*:refs/remotes/origin/* +refs/pull/3580/merge:refs/remotes/pull/3580/merge
fatal: couldn't find remote ref refs/pull/3580/merge
##[error]Git fetch failed with exit code: 128

Will restart

@stepanblyschak
Copy link
Contributor Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

qiluo-msft
qiluo-msft previously approved these changes Nov 22, 2024
@wangxin
Copy link

wangxin commented Nov 26, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
@stepanblyschak
Copy link
Contributor Author

@qiluo-msft @wangxin Could you please help with static analysis? Static analysis fails but I do not see a problem:

config/main.py:7937:21: E128 continuation line under-indented for visual indent

But line 7937 is not even in the diff.

And here I do not see any tabs on those lines in my diff:

tests/vxlan_test.py:374:1: E101 indentation contains mixed spaces and tabs
tests/vxlan_test.py:375:1: E101 indentation contains mixed spaces and tabs
tests/vxlan_test.py:376:1: E101 indentation contains mixed spaces and tabs
tests/vxlan_test.py:378:1: E101 indentation contains mixed spaces and tabs
tests/vxlan_test.py:379:1: E101 indentation contains mixed spaces and tabs
tests/vxlan_test.py:380:1: E101 indentation contains mixed spaces and tabs
tests/vxlan_test.py:384:1: E101 indentation contains mixed spaces and tabs
tests/vxlan_test.py:385:1: E101 indentation contains mixed spaces and tabs

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants