-
Notifications
You must be signed in to change notification settings - Fork 662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate interface name length in CLI #3580
Open
stepanblyschak
wants to merge
14
commits into
sonic-net:master
Choose a base branch
from
stepanblyschak:master_validate_interface_name_length-new
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Validate interface name length in CLI #3580
stepanblyschak
wants to merge
14
commits into
sonic-net:master
from
stepanblyschak:master_validate_interface_name_length-new
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stepanblyschak
changed the title
Master validate interface name length new
Validate interface name length in CLI
Oct 21, 2024
This was referenced Oct 21, 2024
/azp run Azure.sonic-utilities |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
force-pushed
the
master_validate_interface_name_length-new
branch
from
October 30, 2024 16:13
dc09bad
to
6be74f7
Compare
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
Some git failure:
Will restart |
/azpw run |
/AzurePipelines run |
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
previously approved these changes
Nov 22, 2024
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
Signed-off-by: Stepan Blyschak <[email protected]>
@qiluo-msft @wangxin Could you please help with static analysis? Static analysis fails but I do not see a problem:
But line 7937 is not even in the diff. And here I do not see any tabs on those lines in my diff:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is accompanied by sonic-net/sonic-swss-common#931 and sonic-net/sonic-buildimage#20108
What I did
Validate interface name length does not exceed the limitation of IFNAMSIZ to align to kernel restrictions.
How I did it
Add validation checks in the relevant config functions for the following interface types:
vxlan
vlan
vrf
loopback
subinterface
portchannel
How to verify it
UT tests added
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)