[action] [PR:3062] Fix multi-asic behaviour for ecnconfig (#3062) #3636
+755
−395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes multi-asic behaviour for ecnconfig. Previously, ecnconfig -l was not behaving correctly on multi-asic devices, as the '-n' namespace option was not available, and correct namespaces were not traversed on multi-asic devices to retrieve correct results for ecnconfig. This change fixes multi-asic behaviour of CLI commands that rely on ecnconfig. * tests cleanup * Remove wred on lossy * Addendum to previous commit regarding wred lossy * Enhancements to multi-asic support in ecnconfig - Removed unix socket and fixed failing unit test - Replace argparse with click - Add multi-asic support for get and set queue - Add multi-asic support for set threshold and prob - Modify test framework to support multi-asic - Use multi_asic decorators - Resolve precommit errors --------- Co-authored-by: rdjeric <[email protected]> Co-authored-by: arista-hpandya <[email protected]>
|
Original PR: #3062 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, ecnconfig -l was not behaving correctly on multi-asic devices,
as the '-n' namespace option was not available, and correct namespaces were
not traversed on multi-asic devices to retrieve correct results for ecnconfig.
This change fixes multi-asic behaviour of CLI commands that rely on ecnconfig.
tests cleanup
Remove wred on lossy
Addendum to previous commit regarding wred lossy
Enhancements to multi-asic support in ecnconfig
Co-authored-by: rdjeric [email protected]
Co-authored-by: arista-hpandya [email protected]