-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes in HOSTAPD to Support PAC #90
base: master
Are you sure you want to change the base?
Conversation
Below are the associated PRs for this functionality. #88 HLD PR is below we will raise the remaining functionality in new PRs asap. |
/azpw run Azure |
/AzurePipelines run Azure |
No pipelines are associated with this pull request. |
@jeff-yin @ridahanif96 pls help review |
/azpw run Azure |
/AzurePipelines run Azure |
No pipelines are associated with this pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes Looks Fine. Rerun or push again the code to pass the failed checks
@@ -176,8 +176,10 @@ static void hostapd_clear_old(struct hostapd_iface *iface) | |||
* allow them to use the BSS anymore. | |||
*/ | |||
for (j = 0; j < iface->num_bss; j++) { | |||
#ifndef CONFIG_SONIC_HOSTAPD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The design mentions that the hostapd receive packets directly when the mode is configured as MAB. Can you please help with the APIs for that functionality?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't get the question. The hostapd doesn't or never communicates with MAB directly. It communicates only with PACD. Similarly MAB communicates only with PACD. Can you please point to the section in the design document, if it is mentioned.. will correct the same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry my bad. Somehow I remember seeing that & wanted to check
@@ -176,8 +176,10 @@ static void hostapd_clear_old(struct hostapd_iface *iface) | |||
* allow them to use the BSS anymore. | |||
*/ | |||
for (j = 0; j < iface->num_bss; j++) { | |||
#ifndef CONFIG_SONIC_HOSTAPD |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry my bad. Somehow I remember seeing that & wanted to check
src/drivers/driver_wired.c
Outdated
@@ -33,21 +40,28 @@ | |||
#pragma pack(push, 1) | |||
#endif /* _MSC_VER */ | |||
|
|||
#if 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this code is not required, please remove it.
f3ad674
to
0f79688
Compare
Why I did it
These changes are required to support PAC functionality to interact with 802.1X.
How I did it
How to verify it