[Bug] Troubleshooting HDR Activation in Steamtinkerlaunch #1103
Comments
Riebeck-one
changed the title
|
Does this happen on master? You shouldn't be using v12.12 and shouldn't open issues experienced with anything other than the latest master, as per the issue template (https://github.com/sonic2kk/steamtinkerlaunch/blob/master/.github/ISSUE_TEMPLATE/bug-report.md?plain=1#L13). I don't have any HDR hardware and have no plans for any so I cannot really test anything other than checking if GameScope is being given the flags. Also, please provide a log from game execution as the issue template instructed as well (https://github.com/sonic2kk/steamtinkerlaunch/blob/master/.github/ISSUE_TEMPLATE/bug-report.md?plain=1#L24-L31). |
sonic2kk
added
the
GameScope
|
Double-checked and the flag name didn't change in the GameScope logic between v12.12 and current master (59b421b)
However there was a big overhaul to the GameScope argument parsing, as noted in the changelog (which the issue template noted should be read before opening issues): https://github.com/sonic2kk/steamtinkerlaunch/wiki/Changeloghttps://github.com/sonic2kk/steamtinkerlaunch/wiki/Changelog A noteworthy change that may impact this issue is #1027. In this case, |
|
Sorry for the inconvenience. I installed the latest master, Steamtinkerlaunch is now v14.0.20240503-2. Logs |
|
Does enabling |
|
It looks like when running GameScope with My guess here is that SteamTinkerLaunch is overriding this (at the time you did need to enable both separately, over a year ago) and the fix would be to ignore this option when using GameScope (there's no need to even set it to Perhaps as well the This change on the GameScope side may be in place since they moved to the Wayland backend a few weeks ago. |
|
Yes it is working ! I only had to enable DXVK_HDR in the Game Menu. I didn't have to enable ENABLE_GAMESCOPE_WSI though, it's still disabled in the Gamescope menu. Thank you for your help. |
|
I'll push a change to ignore I think distro packages are now using a Gamescope version with the new Wayland backend so this should be safe to do, we will basically just let GameScope handle setting/unsetting If someone is using an older GameScope version then this would mean HDR wouldn't work for them at all I think without them explicitly setting it in the STL per-game environment variable file, so I'll note this as well for those using a legacy GameScope version - the Wayland backend is a bit problematic for some users so there is reason to not use the latest version of GameScope right now, but I believe there'll be a flag to fall back to SDL instead which would fix that problem and thus there would be no reason to not use the latest GameScope. Happy gaming! |
sonic2kk
added a commit
that referenced
this issue
May 12, 2024
If DXVK_HDR is disabled, GameScope will still be unable to use HDR. We should assume if GameScope HDR is enabled that a user also wants HDR enabled from the DXVK side. There should be no reason to pass --hdr-enabled to GameScope if you don't actually want to use HDR. Fixes #1103.
|
Issue should be fixed as of #1104 in master. The solution I landed on was forcing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
System Information
Issue Description
When using the normal version of Steam with Proton: Adding
gamescope -W 5120 -H 1440 --hdr-enabled --fullscreen %command%to the command parameter of a game allows turning on HDR within it. This method aligns with the instructions outlined in this article : https://zamundaaa.github.io/wayland/2024/05/11/more-hdr-and-color.htmlWith Steamtinkerlaunch set as a Compatibility Tool: Enabling gamescope usage in the gamescope menu of Steamtinkerlaunch does make the game run inside gamescope, but enabling the HDR support option (which is supposed to only add --hdr-enabled to the launch command of gamescope) is not working, or at least it is impossible to enable HDR within games running with it.
The text was updated successfully, but these errors were encountered: