GameScope: Force DXVK_HDR=1 if GameScope HDR is enabled #1104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If DXVK_HDR is disabled, GameScope will still be unable to use HDR. We should assume if GameScope HDR is enabled that a user also wants HDR enabled from the DXVK side. There should be no reason to pass --hdr-enabled to GameScope if you don't actually want to use HDR. Fixes #1103.
|
Noticed while updating the langfiles that the string for HDR nits ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1103.
If DXVK_HDR is disabled, GameScope will still be unable to use HDR. We should assume if GameScope HDR is enabled that a user also wants HDR enabled from the DXVK side. There should be no reason to pass --hdr-enabled to GameScope if you don't actually want to use HDR.
Still need to update langfiles but this should be good to go otherwise.