Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ModOrganizer 2: Finalize Silent Mode #1100

Merged
merged 2 commits into from
Jun 16, 2024
Merged

ModOrganizer 2: Finalize Silent Mode #1100

merged 2 commits into from
Jun 16, 2024

Conversation

sonic2kk
Copy link
Owner

Finalizes the ModOrganizer 2 Silent Mode implementation. While #1097 implemented the logic to make Silent Mode work, this adds some UX touches to make it easier for users to enable.

  • Adds back the "Silent" button on the ModOrganizer 2 Wait Requester, removed a long time ago.
  • Adds silent option to MO2MODE dropdown on Game Menu.
  • Updates the actions on the Wait Requester to actually respect gui/silent/disabled
    • Newly added "Silent" button will start in silent mode
    • Wait Requester timeout will now default to the selected MO2 mode. Before, we only had two; disabled and gui, so we always defaulted to gui as the sensible choice for the Wait Requester timing out. But now it will actually respect whatever the user selected in disabled. Having said that, the Wait Requester should only appear if MO2MODE is not disabled, so the user won't see it if the mode isn't gui or silent anyway.
  • Minor code refactoring

This needs more testing from my side, and once completed this can be merged to fully finalize the MO2 Silent implementation!

Note: I did some work to update the ModOrganizer 2 wiki page, but another pass over it might be good to make sure all the intricacies are documented.

@sonic2kk
Copy link
Owner Author

I've been thinking about the implementation of this, and I may rework it before merging.

@sonic2kk sonic2kk marked this pull request as draft May 26, 2024 00:58
@sonic2kk sonic2kk force-pushed the finalize-mo2-silent branch from 630b68a to cdb9bfa Compare June 16, 2024 00:05
@sonic2kk sonic2kk marked this pull request as ready for review June 16, 2024 00:08
@sonic2kk
Copy link
Owner Author

Eh, I don't think we need to make any changes here. I was concerned that showing the Wait Requester when Silent Mode was enabled wouldn't make sense but there are cases where the Wait Requester timeout may be 0, so in that case Mo2 can be started entirely silently.

I think this is good to merge after a version bump and langfile check.

@sonic2kk sonic2kk merged commit 9c02212 into master Jun 16, 2024
2 checks passed
@sonic2kk sonic2kk deleted the finalize-mo2-silent branch June 16, 2024 05:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant