Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor binary #1468

Open
wants to merge 35 commits into
base: main
Choose a base branch
from
Open

Refactor binary #1468

wants to merge 35 commits into from

Conversation

emricksinisonos
Copy link
Collaborator

No description provided.

@emricksinisonos emricksinisonos marked this pull request as ready for review October 9, 2024 21:27
@emricksinisonos emricksinisonos force-pushed the refactor-binary branch 2 times, most recently from 3292d9a to 0e887d1 Compare October 15, 2024 21:37
kali
kali reviewed Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@kali kali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets's hace a chat later today :)

core/src/ops/mod.rs Outdated Show resolved Hide resolved
data/src/tensor/indices.rs Outdated Show resolved Hide resolved
linalg/src/arm64/arm64fp16/by_scalar.rs Show resolved Hide resolved
linalg/src/frame/by_scalar.rs Show resolved Hide resolved
linalg/src/lib.rs Show resolved Hide resolved
@emricksinisonos
shapes indicies iterator + collapse_axis in tensorview
fd0e2b4
@emricksinisonos
Introduce BinOpByScalar & BinOpUnicast
6b548ba
@emricksinisonos
Add serialization of BinOpByScalar + BinOpUncast
b5c4213
@emricksinisonos
Fix unicast & avoid quant bin op declutter
3dc6ef0
@emricksinisonos
conversion in optimize instead of declutter
8ebcc27
@emricksinisonos
Add declutter neutral to typed op
a261eb0
@emricksinisonos
Fix clippy
0e4f467
@emricksinisonos
Dirty plug in linalg
87fe789
@emricksinisonos
Create by_scalar & unicast registries in linalg
cc4c570
@emricksinisonos
Fix import
206be0a
@emricksinisonos
BinOpX are slower ..
b37e6ef
@emricksinisonos
Replace collapse_axis with prefix_with
43a35ab
@emricksinisonos
Introduce LirMul with predefined linalg method
ab606f6
@emricksinisonos
Change naming
bfde055
@emricksinisonos
Reorganize code & remove methods from BinMiniOp trait
b2b8e2f
@emricksinisonos
Add more BinOp support in linalg (Add & Sub)
f16181a
@emricksinisonos
Decluttering to swap operand
675903b
@emricksinisonos
cargo clippy
4f3a0d4
@emricksinisonos
Fix compilation x86
6cb73f3
@emricksinisonos
Fix linalg tests
aa1b007
@emricksinisonos
File renaming
d7fe71e
@emricksinisonos
Fix typo
6de2b9a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kali kali kali left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emricksinisonos @kali