augur-168 Make sure startup errors are reported #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. refactor - move setting reading into separate methods. if there will be errors during parsing setting's value - default value will be used 2. add logger 3. fail_silently usage - if false no exceptions will be raised, they will be logged only
remove logging exceptions
change fail_silently to False
removed unnecessary checks for list and list of tuples
This reverts commit 534e46a.
removed unnecessary checks for lists and list of tuples
deleted DeadlockDetection bootstep by default add directive to pyramid with bootsteps configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
Refactor config values parsing - extracted new methods for each settings type. And wrapped it, so fail_silently passed to read_configuration is false - exception will be raised. In other case exceptions will be logged and setting's default value will be taken