Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PyTorch model reader #1213

Merged
merged 3 commits into from
Sep 12, 2024
Merged

Fix PyTorch model reader #1213

merged 3 commits into from
Sep 12, 2024

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Sep 11, 2024

Pull Request Description:

Fix PyTorch model reader for nodes with list input (e.g. concat), when both inputs are the same tensor (i.e. concat([x, x], dim=2)).

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jsut two minor comments

@elad-c elad-c merged commit b2de9a7 into main Sep 12, 2024
35 checks passed
@elad-c elad-c deleted the torch_reader_fix branch September 12, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants