Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor hessian service and torch sample layer attention. #1242

Merged
merged 16 commits into from
Oct 22, 2024
Merged

Conversation

irenaby
Copy link
Collaborator

@irenaby irenaby commented Oct 14, 2024

Pull Request Description:

Refactor hessian service.
Add data util for torch.
Update GPTQ trainer - use new data loader for samples and corresponding loss weights, rewrite SLA.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby requested a review from ofirgo October 15, 2024 08:34
@irenaby irenaby force-pushed the refactor2 branch 2 times, most recently from 097f7f1 to 762ddee Compare October 15, 2024 12:39
Copy link
Collaborator

@ofirgo ofirgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still need to go over the tests but in the meanwhile leaving some comments

@irenaby irenaby merged commit cfb313c into main Oct 22, 2024
34 of 35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants