Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove imx500 tutorials #1249

Closed
wants to merge 1 commit into from
Closed

remove imx500 tutorials #1249

wants to merge 1 commit into from

Conversation

Idan-BenAmi
Copy link
Collaborator

Pull Request Description:

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

ofirgo
ofirgo requested changes Oct 22, 2024
View reviewed changes
tutorials/README.md
| Tutorial | Included Features |
|--------------------------------------------------------------------------------------------|-----------------------------------------------------------------------------------------------------|
| [Basic Post-Training Quantization (PTQ)](keras/example_keras_post-training_quantization.ipynb) | ✅ PTQ |
| [MobileNetV2](../imx500_notebooks/keras/example_keras_mobilenetv2_for_imx500.ipynb) | ✅ PTQ |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are several tutorials here that refer to IMX500 tutorials, they need to be removed

tutorials/resources/utils/keras_tutorial_tools.py
@@ -1,164 +0,0 @@
# Copyright 2024 Sony Semiconductor Israel, Inc. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure that none of the feature tutorials use the utils? (keras or pytorch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ofirgo ofirgo ofirgo requested changes

Assignees
No one assigned
Labels
auto:tutorials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Idan-BenAmi @ofirgo