Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Gaussian with Rademacher distribution in hessian estimation #1250

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

irenaby
Copy link
Collaborator

@irenaby irenaby commented Oct 22, 2024

Pull Request Description:

replace Gaussian with Rademacher distribution in hessian estimation for torch

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@irenaby irenaby marked this pull request as ready for review October 22, 2024 06:31
@irenaby irenaby marked this pull request as draft October 22, 2024 06:31
@irenaby irenaby requested a review from ofirgo October 22, 2024 06:31
@irenaby irenaby changed the base branch from refactor2 to main October 22, 2024 08:22
@irenaby irenaby changed the base branch from main to refactor2 October 22, 2024 08:23
@irenaby irenaby changed the base branch from refactor2 to main October 22, 2024 08:28
@irenaby irenaby marked this pull request as ready for review October 22, 2024 08:47
@irenaby irenaby merged commit b253ebd into main Oct 22, 2024
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants