ADD :: 사람 추가 api (#63) #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- querydsl 사용하기 위한 custom repository 추가 - authority 동적쿼리
- 현재 필수값이 아닌데 응답을 하지 않은 경우 Null로 저장되어 공간이 낭비되고 있었음 - 해당 경우에 값을 저장하지 않도록 수정함
- question에 type 추가 - reply에 questino id추가 - null check를 하기 위함
- query reply 할 때 필수가 아닌 값 null처리해줌
- 설명 size validation을 주지 않아서 서버 에러 오류로 뜨는 현상 발생 - size validation 추가 - 기존 200자 -> 500자로 수정
Reflect Hotfix
- 사람 타입 추가 - 사람 쿼리할 때 이름으로 쿼리하도록 변경 - searh response 변경
- search user에 통합
Feat/user input
gimhanul
reviewed
Mar 30, 2023
src/main/java/com/soogung/simblue/domain/group/presentation/GroupController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/soogung/simblue/domain/group/presentation/dto/request/MemberRequest.java
Outdated
Show resolved
Hide resolved
Yunyeong-Ko
force-pushed
the
feat/#63-add
branch
from
95e119e to
7e55eb1
Compare
gimhanul
reviewed
Mar 31, 2023
src/main/java/com/soogung/simblue/domain/group/service/JoinGroupService.java
Outdated
Show resolved
Hide resolved
src/main/java/com/soogung/simblue/domain/group/presentation/MemberController.java
Outdated
Show resolved
Hide resolved
src/main/java/com/soogung/simblue/domain/group/domain/repository/GroupRepository.java
Outdated
Show resolved
Hide resolved
Yunyeong-Ko
force-pushed
the
feat/#63-add
branch
2 times, most recently
from
146be92 to
ea179ca
Compare
Yunyeong-Ko
force-pushed
the
feat/#63-add
branch
from
ea179ca to
7e55eb1
Compare
- .env 환경변수 추가 - redis docker-compose 설정 - action 환경변수 설정 변경
Hotfix/refresh token
Reflect Hotfix
Reflect Fix
gimhanul
approved these changes
Apr 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 Summary
🔨 Tasks
🙋🏻 More
close #63