[Feature/#906] soptamp report api 연결 및 웹뷰 연결 #911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
l2hyunwoo
reviewed
Oct 14, 2024
Comment on lines
109
to
112
| val state by missionsViewModel.state.collectAsState() | ||
| val generation by missionsViewModel.generation.collectAsState() | ||
| val nickname by missionsViewModel.nickname.collectAsState() | ||
| val reportUrl by missionsViewModel.reportUrl.collectAsState() |
There was a problem hiding this comment.
이거 바꾸는 김에 collectAsStateWithLifecycle...
leeeyubin
reviewed
Oct 14, 2024
Comment on lines
142
to
+146
| Box( | ||
| modifier = Modifier.pullRefresh(refreshingState) | ||
| modifier = Modifier | ||
| .pullRefresh(refreshingState) | ||
| .background(SoptTheme.colors.white) | ||
| .fillMaxSize() |
There was a problem hiding this comment.
Modifier에 pullRefresh 기본 속성이 있는지 몰랐네요...!
l2hyunwoo
force-pushed
the
feature/#906-soptamp-report
branch
from
e098293
to
aaeab4d
Compare
collectAsStateWithLifecycle
…-makers/sopt-android into feature/#906-soptamp-report
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this issue?
Reference
soptamp.mp4