Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactor/#922] 오늘의 솝마디 콕찌르기 BaselineProfile & Spotless 적용 #929

Merged
merged 104 commits into from
Oct 21, 2024
Merged

[Refactor/#922] 오늘의 솝마디 콕찌르기 BaselineProfile & Spotless 적용 #929

merged 104 commits into from
Oct 21, 2024

Conversation

s9hn
Copy link
Contributor

@s9hn s9hn commented Oct 21, 2024 •
edited
Loading

What is this issue?

  • BaselineProfile & Spotless 적용

s9hn and others added 30 commits September 25, 2024 16:23
@s9hn
feat: TodayFortuneBox 구현
1aa4880
@s9hn
feat: 오늘의 운세(TodayFortuneDashboard) UI 구현
427fcc1
@s9hn
feat: FortuneDetailRoute, FortuneDetailScreen 파일 분리
1a75a66
@s9hn
refactor: 패키지 네이밍 수정
e265c4e
@s9hn
feat: fortune 데이터레이어 구현
3b483ac 
- di 모듈 추가
- network api 구현
@s9hn
feat: fortune 도메인레이어 구현, internal 키워드 일괄 적용
4241e3f 
- mapper 구현
- 레포지토리 인터페이스 생성 및 적용
- 힐트모듈 수정
@s9hn
refactor: internal 키워드 삭제
533a29f
@s9hn
refactor: 함수 네이밍 수정
f655b50
@s9hn
feat: 레이어 의존성 추가
e26989c
@s9hn
refactor: 네트워크 path 수정
5950cec
@s9hn
feat: 네트워크 통신 구현 및 state 적용
71001df
@s9hn
feat: 오늘의 솝마디 관련 유즈케이스 생성
1e42c44
@s9hn
refactor: TodayFortuneBox 패딩값 추가
625d11e
@s9hn
refactor: 타입 및 네이밍 수정
430b830
@s9hn
refactor: internal 추가
83c0641
@s9hn
test: FortuneDetailScreenTest 구현
8d86bcb
@s9hn
Merge branch 'develop' of https://github.com/sopt-makers/sopt-android …
340c78e 
…into feature/869
@s9hn
feat: 콕 찌르기 대시보드 UI 구현
2ea3be9
@s9hn
feat: 콕 찌르기 유저 추천 API 연결
37e8027
@s9hn
refactor: UI State 수정 및 적용
0bde946
@s9hn
refactor: SimpleDataFormatter로 리팩터링
2f9ffff
@s9hn
refactor: Timber 적용
69a0acc
@s9hn
build: 의존성 수정
8981910
@s9hn
refactor: break strategy 적용
a7c5b50
@s9hn
build: resolve merge conflict
3c27c00
@s9hn
refactor: 뷰모델 수정
c2ac6ed
@chattymin
feature #875: delete paddingValue
4054429
@chattymin
feature #875: connect TodayFortuneCard api
943f65b
@chattymin
feature #875: connect TodayFortuneCard data
6d0a46c
@chattymin
feature #875: delete paddingValue
ec88717
s9hn added 22 commits October 13, 2024 20:24
@s9hn
refactor: 가독성 개선
c30f067
@s9hn
feat: AmplitudeTracker 구현
4f85182
@s9hn
feat: AmplitudeTracker 적용
daed596
@s9hn
refactor: NDS 적용 및 import 추가
3b931da
@s9hn
refactor: 람다 네이밍 수정
3ec49f9
@s9hn
feat: FortuneDetailErrorDialog 구현
1b15c92
@s9hn
feat: FortuneDetailErrorDialog 및 CircularProgressIndicator 구현, 분기처리
f9cb7d6
@s9hn
refactor: amplitudeTracker 선언 로직 수정
ba84ffe
@s9hn
build: resolve merge conflict
985495e
@s9hn
refactor: 앰플리튜드 수정사항 반영
f66be96
@s9hn
refactor: 뷰모델 함수 네이밍 수정
b4d3248
@s9hn
Merge branch 'develop' of https://github.com/sopt-makers/sopt-android …
6c91b2f 
…into feature/908
@s9hn
build: spotless & baseline
c7aa88b
@s9hn
build: resolve merge conflict
2f8252a
@s9hn
refactor: 오늘의 솝마디 이미지 크기 변경
1b67303
@s9hn
feat: 콕찌르기 완료 스낵바 구현
1543a9a
@s9hn
refactor: 콕찌르기 버튼 isEnabled 구현
04eba4e
@s9hn
Merge branch 'develop' of https://github.com/sopt-makers/sopt-android …
61cc37d 
…into feature/922
@s9hn
refactor: icon, title 변수 할당 및 로직 개선
ed32c51
@s9hn
refactor: 어노테이션 수정
9818234
@s9hn
build: spotless & baselineProfile
a1641aa
@s9hn
build: resolve merge conflict
1970e24
@s9hn s9hn self-assigned this Oct 21, 2024
@s9hn s9hn requested a review from a team as a code owner October 21, 2024 03:34
@height Height
Copy link

height bot commented Oct 21, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

@s9hn s9hn changed the title Feature/922 [Refactor/#922] 오늘의 솝마디 콕찌르기 BaselineProfile & Spotless 적용 Oct 21, 2024
@l2hyunwoo l2hyunwoo merged commit 89eaba4 into develop Oct 21, 2024
1 check passed
@l2hyunwoo l2hyunwoo deleted the feature/922 branch October 21, 2024 03:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@l2hyunwoo l2hyunwoo l2hyunwoo approved these changes

Assignees

@s9hn s9hn

Labels
size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@s9hn @l2hyunwoo @chattymin