Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧Add switches to toggle protocols #535

Merged
merged 8 commits into from
Sep 5, 2024
Merged

Conversation

MattPoblete
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Aug 30, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 4, 2024 3:21am

@esteblock esteblock marked this pull request as ready for review September 3, 2024 13:17
Copy link
Member

@esteblock esteblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @MattPoblete
Where as an admin I can define what protocols the users will be exposed on each network?
Can you please write documentation about this in the README

@MattPoblete
Copy link
Collaborator Author

MattPoblete commented Sep 3, 2024

Protocols sholud be defined by network.
Mainnet:

  • Soroswap
  • SDEX
    Testnet:
  • Soroswap
  • Phoenix

@esteblock esteblock marked this pull request as draft September 3, 2024 14:02
@esteblock
Copy link
Member

@esteblock I will test frontend tests
yar ci run

@MattPoblete
Copy link
Collaborator Author

image
Github workflow randomly failing navigation tests but they are passing in local instance & manual testing

@MattPoblete
Copy link
Collaborator Author

image
workflow approved!

@MattPoblete
Copy link
Collaborator Author

@esteblock I will test frontend tests yar ci run

please run: yarn cy:run

@esteblock esteblock merged commit 62df674 into main Sep 5, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 User should decide or not to use SDEX or Soroswap (Soroban) Aggregator
2 participants