Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/volume-issue-#79 #83

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

suhas-sensei
Copy link

[WIP] Fix: Volume Calculation to Only Consider Swap Events (#79)

  • Volume incorrectly included add/remove liquidity events, should only count swaps
  • Updated event filtering and volume calculation in services layer
  • Fixed type issues and improved error handling

Testing Required:

  • Create test API endpoint with sample swap/liquidity events
  • Check date grouping and formatting
  • Validate error handling

Copy link

vercel bot commented Nov 1, 2024

@suhas-sensei is attempting to deploy a commit to the PaltaLabs OU Team on Vercel.

A member of the Team first needs to authorize it.

@suhas-sensei
Copy link
Author

@esteblock please check discord

@esteblock esteblock marked this pull request as ready for review November 4, 2024 20:07
Copy link

vercel bot commented Nov 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
info ❌ Failed (Inspect) Nov 13, 2024 11:16am

@esteblock
Copy link
Member

This is failing.
Please fix
image

@suhas-sensei

@esteblock
Copy link
Member

Hello @suhas-sensei ?

@suhas-sensei
Copy link
Author

sending final pr in 8hrs

@suhas-sensei
Copy link
Author

@esteblock i hope there are no more build errors, but if i could find a documentation regarding how to get the values, i could test my changes out. Really sorry for the delay because i got into a little technical issues with my setup.

@esteblock
Copy link
Member

Hello @suhas-sensei this is sad because you still have build errors

image

Did you try with yarn build?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants