-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solver independent interpolation #432
Draft
baierd
wants to merge
326
commits into
master
Choose a base branch
from
solver_independent_interpolation
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1,102
−92
Draft
Changes from 1 commit
Commits
Show all changes
326 commits
Select commit
Hold shift + click to select a range
804fff5
Comment method getFreeArithVars
stefaniesinner 59165e9
Comment method getSharedVars
stefaniesinner a8d1181
Comment method getModelBasedInterpolant
stefaniesinner b99c104
Model ITP: Replace addConstraint with push to assert and create formu…
stefaniesinner 5d7a646
Model ITP: Add unsupported operation exception in method getTreeInter…
stefaniesinner 96cfd9d
Model ITP: Change return type of method getFreeArithVars from ArrayLi…
stefaniesinner e8cf81d
Model ITP: Delete unused import statement
stefaniesinner 6c3cf42
Model ITP: Simplify method name of getFreeArithVars to getVars
stefaniesinner 6e484a3
Model ITP: Simplify parameter name in getVars method from pFormulas t…
stefaniesinner da150fd
Model ITP: Simplify parameter name in getSharedVars method from pVars…
stefaniesinner 0586b45
Model ITP: Rename method getModelBasedInterpolant to computeModelBase…
stefaniesinner b0e69f6
Model ITP: Store the currently asserted formulas in the stack in the …
stefaniesinner abdb70b
Model ITP: Create new method clearStack to remove all asserted formul…
stefaniesinner f3eecc2
Model ITP: Create new method restoreStack to restore the original stack
stefaniesinner 8160112
Model ITP: Call and return the result of method computeModelBasedInte…
stefaniesinner 79c72ce
Model ITP: Extract the process of generating an ITP by declaring and …
stefaniesinner d4278aa
Model ITP: Refactor of method
stefaniesinner c92b52a
Model ITP: Delete pop statement in computeModelBasedInterpolant
stefaniesinner 4a544d7
Model ITP: Improve return type and documentation of method computeMod…
stefaniesinner e253825
QE ITP: Create method getQEBasedInterpolant and declare and initializ…
stefaniesinner 32f80ec
QE ITP: Create method getForwardInterpolant
stefaniesinner 743f249
QE ITP: Create method getBoundVars and declare and initialize boundVa…
stefaniesinner 55442f2
QE ITP: Check if boundVars is empty and perform QE if needed and retu…
stefaniesinner 3a667c3
QE ITP: Refactor of method getBoundVars. Instead of returning an pote…
stefaniesinner 7b3750a
QE ITP: Implement method getBackwardInterpolant
stefaniesinner b5e5cad
QE ITP: Delete unused import statement
stefaniesinner 2b55725
ITP: Assert 'ip0 != null' in class IndependentInterpolation
stefaniesinner 2706cd5
ITP TESTING: Add option for model-based and QE-based solver independe…
stefaniesinner cf4770e
ITP TESTING: Add a new parameter to parametrized tests in SolverBased…
stefaniesinner fb7006a
ITP TESTING: Rename class from ParameterizedSolverBasedTest0 to Param…
stefaniesinner 91967ec
Revert "ITP TESTING: Rename class from ParameterizedSolverBasedTest0 …
stefaniesinner 2fd79b4
Revert "ITP TESTING: Add a new parameter to parametrized tests in Sol…
stefaniesinner 1b42857
Reapply "ITP TESTING: Add a new parameter to parametrized tests in So…
stefaniesinner dc56f9c
Revert "Reapply "ITP TESTING: Add a new parameter to parametrized tes…
stefaniesinner ca73df6
ITP TESTING: Create new class ParameterizedInterpolatingSolverBasedTe…
stefaniesinner 5261d84
ITP TESTING: Update prover environment in class InterpolatingProverTe…
stefaniesinner 7a52c4e
QE ITP: Add documentary to methods
stefaniesinner d1346a2
ITP Testing: Fix parameter mismatch in ParameterizedInterpolatingSolv…
stefaniesinner 4975855
ITP Testing: Delete unused import statement
stefaniesinner 5b0f5df
ITP Testing: Rename parameter itpStrategies to itpStrat in Parametriz…
stefaniesinner 2cf9804
ITP Testing: Rename method itpStrategiesToUse to itpStrategyToUse in …
stefaniesinner 009d20d
QE ITP: Check interpolation criteria of QE based interpolation in Abs…
stefaniesinner edefbab
Revert "QE ITP: Check interpolation criteria of QE based interpolatio…
stefaniesinner 1f0ef45
ITP Testing: Comment and reorder prover options to interpolation stra…
stefaniesinner cd1e412
ITP: Improved documentary to the methods of model-based and quantifie…
stefaniesinner c1677db
Remove unnecessary changes to constructors of all solver provers and …
0a337e3
Format InterpolatingProverTest
0838d33
Derive Boolean/Uf/Quantifier Managers from the FormulaManager in Abst…
6a1ab28
Add general method to derive the sets of BooleanFormulas A and B for …
f9d66d7
Restore proper generics and default behavior for non interpolating pr…
bc69b77
Create test interpolating prover with options and check interpolation…
a3ca5a3
Update SolverContext independent interpolation options documentation …
f610af2
Update interpolation base test framework to use arrays per default to…
e68cca5
Suppress unused warnings in IndependentInterpolation and format
e390cf1
Switch concrete types back to generics or Void in many more theorem p…
133a02b
Remodel solver independent prover into a delegate using class that ca…
2a54c69
Use the independent delegate-wrapper to interpolate using Z3 (that do…
e628f75
Change the chosen Solver from Z3 to CVC5 in the example class for sol…
stefaniesinner c7e07fc
Create and use an distinct prover to interpolate on
stefaniesinner 35b505d
Add solver-independent interpolation procedures for all Solvers and m…
stefaniesinner 01bfea1
Simplify model based interpolation code
23e1007
Throw a exception for tree interpolants for independent interpolation…
6404f67
Add TODOs for uniform interpolation and simplify uniform interpolatio…
71b1a06
Add TODO for model based interpolants
c26bd11
Make interpolation strategy used readable in tests
6b826ab
Format
f40e3d1
Describe the purpose of the class InterpolationFormulas as helper cla…
stefaniesinner f0400b1
Delete unnecessary prover option GENERATE_MODELS in the example class…
stefaniesinner 72c70a5
Some clean up in class IndependentInterpolatingProverEnvironment (rep…
stefaniesinner 87550f8
Delete the unnecessary methods clearStack and restoreStack
stefaniesinner d6b9d55
Describe purpose of method hasIndependentInterpolationStrategy to che…
stefaniesinner 1ac1500
Rewrite TODO. The native solver interpolation does not work in Indepe…
stefaniesinner 61e6e3f
Expand the UnsupportedOperationException in getInterpolant with a err…
stefaniesinner 53b303d
Make sure that the sets of formulas for A and B cannot be null with P…
stefaniesinner b2f7cae
Model ITP: Rename method for clean up
stefaniesinner bcf9fa0
Model ITP: Rename parameters and variables for clean up
stefaniesinner 710996f
Model ITP: Extend, correct, and improve the documentation for the get…
stefaniesinner 09f14ee
Model ITP: Handle empty sets of variables, as they can not be quantif…
stefaniesinner 6b55522
QE ITP: Extend, correct and improve documentation for method getQuant…
stefaniesinner e25328c
QE ITP: Check variables in getQuantifierEliminationBasedInterpolant w…
stefaniesinner 4b980e5
QE ITP: Check current asserted set of formulas whether it is SAT or U…
stefaniesinner e0db2f2
QE ITP: Verify that interpolationStrategy is not null to make the war…
stefaniesinner 9aefa8c
QE ITP: Refactor and make false as default output for interpolant.
stefaniesinner c6b3062
QE ITP: Implement method satisfiesInterpolationCriteria to verify whe…
stefaniesinner 1c315a0
QE ITP: Comment method satisfiesInterpolationCriteria to understand t…
stefaniesinner 4fe40ed
QE ITP: Make sure that the resulted interpolant satisfies the definit…
stefaniesinner 481a523
QE ITP: Reposition getBackwardInterpolant method for clean up
stefaniesinner 96ad41e
QE ITP: Catch possible exception and rethrow with additional informat…
stefaniesinner 1503de8
QE ITP: Improve documentation for method getBackwardInterpolant for b…
stefaniesinner ff6d9d3
QE ITP: Catch possible exception and verify that the quantifier has b…
stefaniesinner 7272e34
QE ITP: Improve documentation of getForwardInterpolant method for bet…
stefaniesinner cf5d74b
ITP: Improve documentation for method getVars for better understanding.
stefaniesinner f16392e
ITP: Improve documentation for method getSharedVars for better unders…
stefaniesinner 1858bc8
ITP: Simplify method getBoundVars.
stefaniesinner d90ba1f
ITP: Improve documentation of getBoundVars method for better understa…
stefaniesinner 653d9be
ITP: Simplify and improve documentation of getUniqueInterpolant.
stefaniesinner d15ed54
ITP: Describe purpose of getDistinctProver method.
stefaniesinner d0caccf
ITP: Delete TODO: use context to create distinct provers to interpola…
stefaniesinner 48a03bf
Some clean up and renaming of parameters.
stefaniesinner 11b6fb6
Delete Preconditions for formulas of A and formulas of B since class …
stefaniesinner 5856c69
Use InterpolatingProvers as delegate for independent interpolation pe…
33b5f40
Allow tree interpolants for delegates of the independent interpolatio…
4a06fee
Allow sequential interpolants through the native delegate in the inde…
ad93319
Use the native ITP-BacktrackPoints if possible
2a7a580
Properly instantiate a quantified formula manager for Yices2 and use …
cf003ac
Format
bcf7a02
Delete @SuppressWarnings annotation since this is not needed anymore.
stefaniesinner d6a574d
Change variable allIndependentInterpolationStrategies to a constant
stefaniesinner a763186
Throw an IllegalArgumentException for cases where the interpolation g…
stefaniesinner 45e0fec
Throw an IllegalArgumentException for set of variables that are empty…
stefaniesinner c9af0d9
Throw same IllegalArgumentException for set of variables that are emp…
stefaniesinner 3023670
Instead of null use Optional, avoiding null that needs explicit check…
stefaniesinner 634dc9b
Revert "Instead of null use Optional, avoiding null that needs explic…
stefaniesinner 3ef2af9
Throw InvalidConfigurationException in method getIndependentInterpola…
stefaniesinner eeca464
Revert "Throw InvalidConfigurationException in method getIndependentI…
stefaniesinner 024d76e
Remove DOCTYPE restriction from ivysetting in build folder to build t…
f520628
Remove unneeded quantified and boolean formula managers from Yices2So…
91fb466
Format AbstractProver JavaDoc
cb6e9f3
Remove InterruptManager from solver independent interpolation wrapper…
295ebf3
Suppress warnings for resources for the new independent solver provers
838e727
Merge 5.0.0 into feature branch solver_independent_interpolation
d3ec3dd
Replace ecj.jar dependency from version 4.29 to 4.11 in ivy.xml to fi…
stefaniesinner 9854c77
Delete unused import statements in AbstractProver
stefaniesinner 834b30d
Manage itpProver by try-with-resource for the solver than itpProver.c…
stefaniesinner f5170f6
Revert "Replace ecj.jar dependency from version 4.29 to 4.11 in ivy.x…
stefaniesinner a858290
Return false for interpolant in both independent interpolation strate…
stefaniesinner 70a14da
Return true as interpolant if the conjunctive set of formulas A evalu…
stefaniesinner 8e408c4
Return false as interpolant if the conjunctive set of formulas A eval…
stefaniesinner 20f93d4
Comment that depending on the SMT solver, pre-processing might rewrit…
stefaniesinner bc92f6a
Return ugly null as empty interpolant in case both sets of formulas A…
stefaniesinner 7276624
Correct case if varsOfA and/or varsOfB is empty. If at least one of t…
stefaniesinner 98f48e0
Correct case if varsOfA and/or varsOfB is empty. If at least one of t…
stefaniesinner 4e13d81
Check the case that the sets of formulas A and B are both empty and r…
stefaniesinner 9508a5b
Return true as interpolant if both conjunctive sets of formulas A and…
stefaniesinner b6b2a2f
Combine the sets of formulas A in a single BooleanFormula using conju…
stefaniesinner 24207c3
Handle empty interpolation groups by assigning TRUE to conjugatedA ex…
stefaniesinner aaa0db1
ITP Tests: Handle empty interpolation groups for independent interpol…
stefaniesinner 0b2dfff
ITP Tests: Handle sequential interpolation. Sequential interpolants a…
stefaniesinner b0196b2
ITP Tests: Handle tree interpolation. Tree interpolants are not suppo…
stefaniesinner f23b2c6
ITP Tests: Assume Z3 run into timeout on the test binaryBVInterpolati…
stefaniesinner d2b0aa0
ITP Tests: Add requireSequentialInterpolation to other tests
stefaniesinner 930a6a1
Revert "ITP Tests: Add requireSequentialInterpolation to other tests"
stefaniesinner 49f3f8f
Revert "ITP Tests: Assume Z3 run into timeout on the test binaryBVInt…
stefaniesinner cea0073
Revert "ITP Tests: Handle tree interpolation. Tree interpolants are n…
stefaniesinner 51fa4fa
Revert "ITP Tests: Handle sequential interpolation. Sequential interp…
stefaniesinner 5cd5643
Reapply "ITP Tests: Assume Z3 run into timeout on the test binaryBVIn…
stefaniesinner d4a31e7
ITP Tests: Handle sequential interpolation. Sequential interpolants a…
stefaniesinner 7099f94
ITP Tests: Extend test requireTreeItp with cases for independent inte…
stefaniesinner 882332e
ITP Tests: Handle tree interpolation. Tree interpolants are not suppo…
stefaniesinner a8f8df8
ITP: Check with a distinct prover, if the set of formulas A is satisf…
stefaniesinner b12c6b9
Revert "ITP: Check with a distinct prover, if the set of formulas A i…
stefaniesinner 7c45f90
Revert "ITP Tests: Handle empty interpolation groups for independent …
stefaniesinner 11d684e
ITP: Check with a distinct prover, if the set of formulas A is satisf…
stefaniesinner 85676b9
ITP Test: Check whether the condition is met to run test binaryInterp…
stefaniesinner 06e09ea
ITP Test: Check again whether the chosen interpolation strategy suppo…
stefaniesinner 7bc0e77
Revert "ITP Test: Check again whether the chosen interpolation strate…
stefaniesinner ff8c679
Revert "ITP Test: Check whether the condition is met to run test bina…
stefaniesinner 5d05d5a
ITP Test: Skip test binaryInterpolation for BOOLECTOR, since the solv…
stefaniesinner 3145177
ITP Test: Since it seems to be a test for sequential interpolants, th…
stefaniesinner 8ea6495
ITP Test: Since it seems to be a test for sequential interpolants, th…
stefaniesinner 1407c09
Revert "ITP Tests: Handle tree interpolation. Tree interpolants are n…
stefaniesinner b548175
ITP Test: Skip the two tests issue381InterpolationTest2 and 3 for now…
stefaniesinner 0ac2878
ITP Test: Skip tests for independent interpolation strategies with BI…
stefaniesinner 2b426ca
Revert "ITP Test: Skip tests for independent interpolation strategies…
stefaniesinner 9589acd
ITP: Throw a simple IllegalArgumentException for an empty interpolati…
stefaniesinner c547246
Reapply "ITP Tests: Handle empty interpolation groups for independent…
stefaniesinner 2536ac4
ITP: Change back the check for independent interpolation strategies a…
stefaniesinner e412de4
ITP Test: assertThrows for UnsupportedOperationExceptions should neve…
stefaniesinner 8923d02
Revert "ITP Tests: Extend test requireTreeItp with cases for independ…
stefaniesinner 154385c
ITP Test: assume that independent interpolation strategies do not sup…
stefaniesinner 66c05a0
disable Yices2 quantifiers, as they have problems (TODO: investigate)
10a16c1
Allow native interpolation with the independent interpolation wrapper…
989e556
Check for quantifier support for interpolation when checking if an in…
07725c4
Revert "ITP Test: assume that independent interpolation strategies do…
stefaniesinner 704860f
Reapply "ITP Tests: Extend test requireTreeItp with cases for indepen…
stefaniesinner b51dfad
Revert "ITP Test: assertThrows for UnsupportedOperationExceptions sho…
stefaniesinner b7b5e6b
Revert "ITP: Change back the check for independent interpolation stra…
stefaniesinner dbfee25
Revert "Reapply "ITP Tests: Handle empty interpolation groups for ind…
stefaniesinner 2ee7076
Revert "ITP: Throw a simple IllegalArgumentException for an empty int…
stefaniesinner de97696
Reapply "ITP Test: Skip tests for independent interpolation strategie…
stefaniesinner fbe0503
Revert "ITP Test: Skip tests for independent interpolation strategies…
stefaniesinner 2494662
Revert "ITP Test: Skip the two tests issue381InterpolationTest2 and 3…
stefaniesinner 8db39e8
Reapply "ITP Tests: Handle tree interpolation. Tree interpolants are …
stefaniesinner 47dbe5a
Revert "ITP Test: Since it seems to be a test for sequential interpol…
stefaniesinner 766a017
Revert "ITP Test: Since it seems to be a test for sequential interpol…
stefaniesinner 3b27329
Revert "ITP Test: Skip test binaryInterpolation for BOOLECTOR, since …
stefaniesinner 2a3679c
Reapply "ITP Test: Check whether the condition is met to run test bin…
stefaniesinner b1a18d5
Reapply "ITP Test: Check again whether the chosen interpolation strat…
stefaniesinner e8c70c8
Revert "ITP Test: Check again whether the chosen interpolation strate…
stefaniesinner fee3938
Revert "ITP Test: Check whether the condition is met to run test bina…
stefaniesinner 2f63151
Revert "ITP: Check with a distinct prover, if the set of formulas A i…
stefaniesinner 67bd5f0
Reapply "ITP Tests: Handle empty interpolation groups for independent…
stefaniesinner b449ac2
Reapply "ITP: Check with a distinct prover, if the set of formulas A …
stefaniesinner 94f277c
Revert "ITP: Check with a distinct prover, if the set of formulas A i…
stefaniesinner b9934b8
Revert "ITP Tests: Handle tree interpolation. Tree interpolants are n…
stefaniesinner 3563966
Revert "ITP Tests: Extend test requireTreeItp with cases for independ…
stefaniesinner 5748cff
Revert "ITP Tests: Handle sequential interpolation. Sequential interp…
stefaniesinner ecde8bc
Revert "Reapply "ITP Tests: Assume Z3 run into timeout on the test bi…
stefaniesinner 1c43a01
Reapply "ITP Tests: Handle sequential interpolation. Sequential inter…
stefaniesinner 6a59be7
Reapply "ITP Tests: Handle tree interpolation. Tree interpolants are …
stefaniesinner 0d08f2c
Reapply "ITP Tests: Assume Z3 run into timeout on the test binaryBVIn…
stefaniesinner 1d1ff71
Reapply "ITP Tests: Add requireSequentialInterpolation to other tests"
stefaniesinner b54917f
Revert "ITP Tests: Add requireSequentialInterpolation to other tests"
stefaniesinner b5de85e
Revert "ITP Tests: Assume Z3 run into timeout on the test binaryBVInt…
stefaniesinner 9d85270
Revert "ITP Tests: Handle tree interpolation. Tree interpolants are n…
stefaniesinner 783c113
Revert "ITP Tests: Handle sequential interpolation. Sequential interp…
stefaniesinner 33fda8c
Revert "ITP Tests: Handle empty interpolation groups for independent …
stefaniesinner 032cc00
ITP Test: Create and implement two test methods requireIndependentTre…
stefaniesinner deb6bdf
ITP: Move the initialization of the variables varsOfA, varsOfB and sh…
stefaniesinner 2956b26
ITP: Delete case if both sets of formulas A and B are trivially TRUE,…
stefaniesinner 5cd5bf1
ITP: Simplify the handling of trivial empty interpolants by returning…
stefaniesinner ff28d41
ITP: Add the case when the shared variables are empty. In this case, …
stefaniesinner 7f027a5
ITP: Improve the documentation of the methods getModelBasedInterpolan…
stefaniesinner 316a0df
ITP: Add @SuppressWarnings("unused") to getIndependentInterpolationST…
stefaniesinner 161fdb7
ITP: Assign the QuantifiedFormulaManager in method getIndependentInte…
stefaniesinner 17d2aa7
ITP: Skip tests issue381InterpolationTest1() and issue381Interpolatio…
stefaniesinner 6b5b04a
ITP Tests: Skip tests using IntegerFormula for solvers not supporting…
stefaniesinner 2403f9a
ITP Tests: Implement method requireIndependentInterpolation to skip t…
stefaniesinner 0c9e319
ITP: Delete the unnecessary, outdated remnants of the implementation …
stefaniesinner 179652c
ITP: Correct implementation for the trivial interpolant B is empty. T…
stefaniesinner 6581fd4
ITP: Simplify checking whether the variables are empty. It is only ne…
stefaniesinner 3dd9ef2
ITP Tests: Replace method requireIndependentInterpolation with requir…
stefaniesinner 2735386
ITP Tests: Replace method requireIndependentInterpolation with requir…
stefaniesinner 1891ccd
Format
stefaniesinner 4b09154
ITP TEST: Skip the test simpleInterpolation() for solver PRINCESS usi…
stefaniesinner 94b18b2
ITP TEST: Skip the test binaryInterpolationWithConstantFalse() for so…
stefaniesinner a5f5f37
ITP TEST: Skip the test issue381InterpolationTest3 for solver Z3 usin…
stefaniesinner 3ec40a6
ITP TEST: Skip the test issue381InterpolationTest3 for solver CVC4, C…
stefaniesinner a68e9e5
ITP TEST: Correct method requireIndependentInterpolationSolvingIssue381
stefaniesinner cfea586
ITP TEST: Format
stefaniesinner 81c7def
ITP Test: Fix error in InterpolatingProverTest. Assumption in sequent…
stefaniesinner fb2f1e4
Rename 'TFormulaInfo' to 'F' and 'TType' to 'T' in class IndependentI…
stefaniesinner 166e7eb
Replace 'import org.sosy_lab.java_smt.api.*;' with specific imports (…
stefaniesinner b0e6d01
ITP QE: Correct quantifier elimination (QE) process in forward and ba…
stefaniesinner c181ed2
Format
stefaniesinner 6fa0483
ITP QE: Introduce two new constants 'SYMBOL_QUANTIFIER_FORALL' and 'S…
stefaniesinner d73afa3
ITP QE: Refactor quantifier elimination strategies by returning the q…
stefaniesinner b47d979
ITP QE: Throw InterruptedException in both quantifier elimination int…
stefaniesinner 154d895
ITP QE: Check if the shared variables still exist and are not elimina…
stefaniesinner 659b812
ITP QE: Improve UnsupportedOperationException from 'Solver does not s…
stefaniesinner 4799dd3
ITP QE: Correct satisfiesInterpolationCriteria by checking the defini…
stefaniesinner a26b698
ITP: Format
stefaniesinner 3bfa46d
ITP Example: Fix spotbug in Pipeline. Bug occurs because the local va…
stefaniesinner a64b151
Reposition @SuppressWarnings("unused") to fix spotbug in Pipeline
stefaniesinner 47af7f3
Use SuppressFBWarnings instead SuppressWarnings to fix spotbug in Pip…
stefaniesinner 9bf25b2
Revert "Use SuppressFBWarnings instead SuppressWarnings to fix spotbu…
stefaniesinner 63db9aa
Fix potential resource leak causing build warning by closing itpProve…
stefaniesinner d7d539c
Fix potential resource leak causing build warning by closing validati…
stefaniesinner 594c372
Reapply "Use SuppressFBWarnings instead SuppressWarnings to fix spotb…
stefaniesinner 8b2b210
Fix build warning with adding SuppressWarnings
stefaniesinner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "ITP Test: assertThrows for UnsupportedOperationExceptions sho…
…uld never be reached. Therefore, delete it" This reverts commit e412de4.
- Loading branch information
commit b51dfad874dd1e6f5ec84f05fd04b84d6111b164
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would imply that this is intented behavior. But we could implement sequential and/or tree interpolants. So i would simply put an assumption at the beginning of the method that does not run this test for solvers/options that don't support it. (see my comment about the
requireTreeInterpolation()
method)This goes for all occurrences of this in this class.