Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LLM Frontend #2554

Closed
wants to merge 28 commits into from
Closed

LLM Frontend #2554

wants to merge 28 commits into from

Conversation

clementlemon02
Copy link

Added default prompt textbox for admin control page.

Changed table format of grades export system.

RichDom2185
RichDom2185 requested changes Jul 18, 2023
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the lint errors and mark the PR as ready again once done. Thanks!

@RichDom2185 RichDom2185 marked this pull request as draft July 18, 2023 05:36
@clementlemon02 clementlemon02 marked this pull request as ready for review July 30, 2023 20:47
RichDom2185
RichDom2185 requested changes Aug 10, 2023
View reviewed changes
Copy link
Member

@RichDom2185 RichDom2185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, I have some comments below.

There seems to be some LLM-unrelated work in this PR?

@coveralls
Copy link

coveralls commented Aug 12, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5922757998

  • 3 of 25 (12.0%) changed or added relevant lines in 4 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.02%) to 37.4%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/commons/dropdown/DropdownCreateCourse.tsx 0 1 0.0%
src/commons/dropdown/DropdownPrompt.tsx 0 3 0.0%
src/pages/academy/adminPanel/subcomponents/CourseConfigPanel.tsx 2 20 10.0%
Files with Coverage Reduction New Missed Lines %
src/pages/academy/adminPanel/subcomponents/CourseConfigPanel.tsx 2 6.38%
Totals Coverage Status
Change from base Build 5922742999: -0.02%
Covered Lines: 5742
Relevant Lines: 14431
💛 - Coveralls

@RichDom2185 RichDom2185 mentioned this pull request Sep 3, 2023
Closed
7 tasks
@RichDom2185 RichDom2185 added the blocking Finishing this opens up other stuff label Sep 3, 2023
@RichDom2185
Copy link
Member

This PR is blocking #2624, which has similar commits and branches off this PR.

@RichDom2185
Copy link
Member

Hi, I have some comments below.

There seems to be some LLM-unrelated work in this PR?

Will split this PR into two chunks instead because of the unrelated commits as this is in danger of becoming stale. Might be superseded soon.

@RichDom2185
Copy link
Member

RichDom2185 commented Sep 3, 2023 •
edited
Loading

I've rebased all changes from this PR to #2656 and #2657 to clean up the history (manually checked all changes line-by-line to ensure correctness); this will make it easier to split the branches into two later on.

@RichDom2185
Copy link
Member

RichDom2185 commented Sep 3, 2023 •
edited
Loading

Superseded by #2656 and #2657.

@RichDom2185 RichDom2185 closed this Sep 3, 2023
This was referenced Sep 3, 2023
Draft
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RichDom2185 RichDom2185 Awaiting requested review from RichDom2185

Assignees
No one assigned
Labels
blocking Finishing this opens up other stuff
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clementlemon02 @coveralls @RichDom2185