Resolve loading indicator issues in grading table #3064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation uses the outdated api.showLoadingOverlay(), which causes issues in loading as the loading logo disappears even before the data arrives. This commit uses the current method of using the "loading" field in the AGGrid component, which solves the loading mismatch issue.
|
ready for review! |
Pull Request Test Coverage Report for Build 11567897786Details
💛 - Coveralls |
RichDom2185
approved these changes
Oct 29, 2024
Hi sayo, apologies for the late reply - it does solve refresh issues for next page / previous page / filters, but not for the dropdown menus for page size or grouping. This is because there wasnt an API to disable them - and I thought it wouldn't be an issue since you couldn't spam backend requests through the dropdown menus easily. Thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3048
Good to do before tackling #2814 so that loading can be more explicity indicated.
This PR resolves the loading indicator bug in the grading table, whereby a request for a new submissions page does not properly get reflected as "loading" until backend data arrives. This problem likely arised due to the use of a deprecated API from AGGrid.
To accompany this change, additional measures have been added to prevent users from spamming new requests while awaiting for data - this disabling is now made possible by the proper loading state.
Description
Type of change
How to test
priv/repo/seeds.exs, example 20000 students and 100 questions. It should be enough such that backend fetching takes at least 1 second.Checklist