Added exam mode #3106
Open
Added exam mode #3106
+1,480
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ausing spinner to show
…s to Playground.tsx for GitHub and Google Drive buttons
RichDom2185
reviewed
Mar 6, 2025
| @@ -15,6 +16,7 @@ type Props = { | |||
|
|
|||
| const DropdownCourses: React.FC<Props> = ({ isOpen, onClose, courses, courseId }) => { | |||
| const navigate = useNavigate(); | |||
| const enableExamMode = useTypedSelector(state => state.session.enableExamMode); | |||
There was a problem hiding this comment.
We can use useSession for simplicity:
Suggested change
| const enableExamMode = useTypedSelector(state => state.session.enableExamMode); | |
| const { enableExamMode } = useSession(); |
src/pages/academy/Academy.tsx
Outdated
Comment on lines
37
to
41
| const { courseId } = useSession(); | ||
| const { courseId: routeCourseIdStr } = useParams<{ courseId?: string }>(); | ||
| const routeCourseId = routeCourseIdStr != null ? parseInt(routeCourseIdStr, 10) : undefined; | ||
| const enableExamMode = useTypedSelector(state => state.session.enableExamMode); | ||
|
|
There was a problem hiding this comment.
useSession is a wrapper around useTypedSelector(state => state.session) among other things
Suggested change
| const { courseId } = useSession(); | |
| const { courseId: routeCourseIdStr } = useParams<{ courseId?: string }>(); | |
| const routeCourseId = routeCourseIdStr != null ? parseInt(routeCourseIdStr, 10) : undefined; | |
| const enableExamMode = useTypedSelector(state => state.session.enableExamMode); | |
| const { courseId, enableExamMode } = useSession(); | |
| const { courseId: routeCourseIdStr } = useParams<{ courseId?: string }>(); | |
| const routeCourseId = routeCourseIdStr != null ? parseInt(routeCourseIdStr, 10) : undefined; | |
…n not an official course, remove exam mode toggle when creating new course
…to report lost/regain of focus
kah-seng
changed the title
…om navbar getting cropped
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Type of change
How to test
Checklist