CSE Machine: Added animation for spread instruction #3114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14290737373Details
💛 - Coveralls |
|
Looking at it, might take a while though since I'm busy |
s-kybound
requested changes
Mar 17, 2025
src/features/cseMachine/animationComponents/ArraySpreadAnimation.tsx
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
3 tasks
martin-henz
changed the title
RichDom2185
reviewed
Apr 6, 2025
craco.config.js
Outdated
There was a problem hiding this comment.
Can you revert the formatting changes to this file (and just this file) too?
There was a problem hiding this comment.
Okay done, but now for some reason the lint coveralls failed Error: Bad response: 405 . Not sure why this is happening
There was a problem hiding this comment.
Probably their service is down, just wait a while
| @@ -28,6 +28,7 @@ export class ArrayAccessAnimation extends Animatable { | |||
| private resultAnimation: AnimatedTextbox; | |||
| private resultArrowAnimation?: AnimatedGenericArrow<StashItemComponent, Visible>; | |||
| private arrayUnit: ArrayUnit; | |||
| private out: boolean; | |||
There was a problem hiding this comment.
What does out mean? Can clarify? From the name, it's not immediately clear what this does
There was a problem hiding this comment.
renamed to outOfRange. if the array access is our of range, outOfRange is false, true otherwise
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Partially deals with #3110, further work can be done on array access out of bounds
Type of change
20250312-1921-34.2597022.mp4
Checklist