Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed package-lock.json and standardize to Yarn. Fixes #29 #30

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

wdym69
Copy link
Contributor

@wdym69 wdym69 commented Sep 18, 2024

Removed package-lock.json and added it to .gitignore.

@wdym69 wdym69 changed the title Removed package-lock.json and standardize to Yarn Removed package-lock.json and standardize to Yarn. Fixes #29 Sep 18, 2024
@martin-henz
Copy link
Member

The package-lock.json file should be committed to ensure consistent installs across all environments. This file locks dependency versions, improving reproducibility and build stability for Source Academy.

@wdym69
Copy link
Contributor Author

wdym69 commented Sep 19, 2024

Thankyou for the comment @martin-henz .
The issue #29 suggests to remove the NPM lockfile (package-lock.json) and standardize to Yarn, hence i did that.
If that seems incorrect, what could be the solution to this issue?

@martin-henz
Copy link
Member

Oh, yes. This is good. Sorry for misunderstanding.

1 similar comment
@martin-henz
Copy link
Member

Oh, yes. This is good. Sorry for misunderstanding.

@martin-henz martin-henz merged commit 062f0e8 into source-academy:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants