use local storage to save repo accessibility #6193
Open
+226
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are always using in-memory cache for calculating
repoVisibility
always. But without passing github token, we frequently hit rate limit for querying github api and cached tokens are evicted from in-memory cache when user refresh. This leads to less data logged for the autocomplete. This PR stores the tokens inlocalStorage
instead of in-memory store to cache the repo visibility.We add the following condition to decide if to set the local storage values:
Other strategies considered.
Test plan