feat(auto-edit): Add more test cases for image rendering #7138
+1,063
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umpox
added a commit
that referenced
this pull request
Feb 20, 2025
https://linear.app/sourcegraph/issue/CODY-4921/auto-edit-support-unified-diff-format-for-image-generations https://github.com/user-attachments/assets/f9a0afdd-7e09-4cd7-85fe-53b99dc1d7fc ## Description This PR: - Adds support for a unified diff format with a different UI. This will be useful for other editors where we do not have support for decorations or will not have it for the MVP - Refactors the image generator feature to use `DecorationInfo` instead of `AddedLinesDecorationInfo`. This means we can easily port this to the inline decorator in a follow up PR. - Generally refactors much of the canvas/highlighting/diff logic. This was necessary to simplify this code as much as possible, as porting to `DecorationInfo` and supporting deletions here adds a lot of checks/edge cases. ## Test plan - Manual testing with both `unified` and `additions` modes enabled - Unit tests that generate images - Further tests in this PR branched from here: #7138 <!-- Required. See https://docs-legacy.sourcegraph.com/dev/background-information/testing_principles. -->
umpox
force-pushed
the
tr/image-unified-diff-tests
branch
from
fb90760 to
43f5d2c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
More test cases for #7000
Test plan
Tests only PR - CI passes