feat(commit message): commit message out of experimental stage #7166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLOSE https://linear.app/sourcegraph/issue/CODY-5048 This commit removes the `experimentalCommitMessage` feature flag and related code. This feature is no longer experimental and is now enabled by default. The following changes were made: - Removed the `experimentalCommitMessage` flag from `lib/shared/src/configuration.ts`, `vscode/src/commands/index.ts`, `vscode/src/testutils/mocks.ts`, `vscode/src/configuration.ts`, `vscode/test/e2e/command-commit.test.ts`, `vscode/src/configuration.test.ts`, and `vscode/package.json`. - Updated the `when` clause for the "Generate Commit Message" command in `vscode/package.json` to remove the check for the `experimentalCommitMessage` setting.
|
how do we make sure this gets captured in a changelog? |
With the new workflow added by @kalanchan it should be added to the changelog automatically when we cut the release 😄 |
valerybugakov
approved these changes
Feb 21, 2025
umpox
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSE https://linear.app/sourcegraph/issue/CODY-5048
This commit removes the
experimentalCommitMessagefeature flag and related code. This feature is no longer experimental and is now enabled by default.The following changes were made:
experimentalCommitMessageflag fromlib/shared/src/configuration.ts,vscode/src/commands/index.ts,vscode/src/testutils/mocks.ts,vscode/src/configuration.ts,vscode/test/e2e/command-commit.test.ts,vscode/src/configuration.test.ts, andvscode/package.json.whenclause for the "Generate Commit Message" command invscode/package.jsonto remove the check for theexperimentalCommitMessagesetting.Test plan
Everything should work as it currently is, including the e2e test.